David J. M. Karlsen wrote:
I'd like to release the 1.0 version of the was6-maven-plugin.
0, not using it. Notes:
The plugin is currently using version 1.5.1 of plexus-utils while the
latest is 1.5.6. Especially the fixes to CLI launching might be of
interest for the plugin.
The site descriptor is unnecessary verbose. The common banner and links
are inherited from the parent and could be removed, compare the plugin
site templates from the Mojo guidelines [0],
Some mojo parameters use "expression=..." rather than
"default-value=..." to inject default values. The later form is
recommended, e.g. to have a nicer goal documentation report.
The title of the faq.apt is not intended as required by the APT spec [1]
which makes the final FAQ render a source snippet block on its top.
Also, the FAQ ends with a source snippet that merely says "TODO".
It would promote best practices if the POM snippets in the examples
included a <version> element for the plugin.
Some example POM/XML snippets use tabs for intendentation, some even
mixed with spaces which makes them harder to read. Two spaces per
indentation level seems to be common for POM formatting.
mvn dependency:analyze reports some discrepancies.
Benjamin
[0] http://mojo.codehaus.org/development/guidelines.html
[1] http://maven.apache.org/doxia/references/apt-format.html
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
