Default binding of goal check to the lifecycle verify phase
-----------------------------------------------------------
Key: MFINDBUGS-65
URL: http://jira.codehaus.org/browse/MFINDBUGS-65
Project: Maven 2.x FindBugs Plugin
Issue Type: Improvement
Affects Versions: 2.0
Reporter: Heidi Vanparys
Attachments: plugin.xml
The plugin.xml file contains the following line for the goal findbugs:check:
<executePhase>verify</executePhase>
meaning 'Invokes the execution of the lifecycle phase verify prior to executing
itself'
I believe it would be better to change this to:
<phase>verify</phase>
which would mean ''Binds by default to the lifecycle phase: verify"
Reasons:
1. this would make the example of "Violation Checking" mentioned on the website
of this plugin work, because now, to make it work, the following lines need to
be present
</configuration>
<executions>
<execution>
<phase>verify</phase>
<goal>check</goal>
</execution>
</executions>
</plugin>
2. If the previous lines are added, and mvn verify is executed, verify will be
called twice (meaning all tests will be run twice..) because findbugs:check is
now invoked when mvn verify is called, but findbugs:check then executes mvn
verify
3. Both pmd:check, pmd:cpd-check and checkstyle:check are described with
'<phase>verify</phase>' in plugin.xml, this would make this findbugs plugin
consistent with those other code checks
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
