David wrote:
While we're at it - why not release the AspectJ plugin as well.
+0, not using it. Notes:
The plugin doesn't require Maven 2.0.9 just to get plexus-utils:1.5.6.
Maven 2.0.6 is sufficient.
The POM inherits from an outdated Mojo parent, thereby producing a bad
mailing list report.
The POM is missing a <description> element.
The site descriptor can be trimmed down, e.g. banners and reports are
inherited. In particular, the name attribute from the <project> element
should be removed to get the proper plugin name into the page titles.
The site has no index page at all.
The example pages lack a title (their first lines merely give a section
title, not a document/page title).
The POM snippets on the site don't include a <version> element for the
plugin.
The mojo parameter
- pluginArtifacts in AjcReportMojo
should be marked as @readonly.
The string-typed mojo parameters
- aspectDirectory
- testAspectDirectory
- ajdtBuildDefFile
- outxmlfile
in the various mojos in combination with the construction
basedir.getAbsolutePath() + "/" + aspectDirectory
will fail when users specify the parameter value as
"${basedir}/src/main/aspect". Switching the parameters to java.io.File
should be sufficient to get proper absolute paths.
Users would benefit if the mojo parameter
- encoding
would adopt the proposal for source file encoding [0].
The hard-coded site output directory
return project.getBuild().getDirectory() + "/site/aspectj-report";
makes customization quite challenging and completely prevents localized
sites but AjcReportMojo.getDescription() isn't localized anyway...
This ended up with a little more than just cosmetic things, just ignore
what doesn't fit the time frame ;-)
Benjamin
[0]
http://docs.codehaus.org/display/MAVENUSER/POM+Element+for+Source+File+Encoding
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
