On Sat, Feb 21, 2009 at 1:36 AM, Benjamin Bentmann <benjamin.bentm...@udo.edu> wrote: > Milos Kleint wrote: > >> I'd like to release nbm-maven-plugin 3.0 > > +0, not using it. Notes: > > "mvn dependency:analyze" reports some undeclared dependencies.
done. > > The POM is missing the <scm> element. Done. I've thought the release plugin would include the correct bits automatically on release. > > The POM inherits from the old mojo-parent:19 which produces a bad JDK > requirement in plugin-info.html. mojo-parent:20 fixed this. done. > > The site descriptor can be trimmed down, i.e. anything but the <menu> should > be inherited from the parent. done. > > "mvn docck:check" reveals that "Parameter: 'outputDirectory' in mojo: > 'autoupdate' is missing a description." done. along with aligning the various outputDirectory, buildDirectory etc names in various mojos to be just one. > > Several mojo parameters referring to build paths are of type String instead > of File, e.g. in BrandingMojo. Without basedir alignment, this gives rise to > errors [0]. done. > >> There are a few incompatible changes, that's why it's 3.0, not 2.7 > > Hm, there are two "@since 2.7" in the code, should these then be updated to > "@since 3.0" as well?. I've done a 2.7 alpha last summer, so I guess the 2.7 tag can stay. thanks for the detailed review. Milos > > > Benjamin > > > [0] > http://maven.apache.org/plugin-developers/common-bugs.html#Resolving_Relative_Paths > > --------------------------------------------------------------------- > To unsubscribe from this list, please visit: > > http://xircles.codehaus.org/manage_email > > > --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
