[
http://jira.codehaus.org/browse/MSCMCHGLOG-10?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emmanuel Hugonnet closed MSCMCHGLOG-10.
---------------------------------------
Resolution: Fixed
Clean most of the mess.
> Clean and refactor the code
> ---------------------------
>
> Key: MSCMCHGLOG-10
> URL: http://jira.codehaus.org/browse/MSCMCHGLOG-10
> Project: Maven 2.x SCM Changelog Plugin
> Issue Type: Improvement
> Components: Report / Mojo
> Affects Versions: 1.0, 1.1
> Reporter: Emmanuel Hugonnet
> Assignee: Emmanuel Hugonnet
> Fix For: 1.2
>
>
> Following the discussion with Mark Struberg
> (http://www.nabble.com/-Vote--Scmchangelog-maven-plugin-tp21832040p21832040.html)
> some refactoring of the plugin is to be done to have clearer code and better
> separation of concern so integrating new scm is easier.
> {quote}Yes I agree with you that I should have an adapter for each scm with
> the current adapter as a wrapper, the question I need to think about is how
> should I inject the correct adapter into the wrapper (through the constructor
> like the ScmManager and the grammar, or with a static map).
> Also I agree with you for the interface SvnGrammar and its descendants which
> should be renamed ScmGrammar etc. The same is to be applied to SvnTargetEnum
> and SvnLogEntry.{quote}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
