Arnaud HERITIER wrote:

  I propose to release the idlj plugin v 1.1.

+0, not using it. Notes:

"mvn dependency:analyze" reports issues with the proper declaration of plexus-utils. Also, the plugin's dependencies include plexus-container-default once from the old group id "plexus" and once from the current one.

There are some javadoc warnings when building the site.

The POM snippet on the usage page does not include a <version> element for the plugin, promoting bad practices.

From TestIDLJMojo:

         * @parameter default-value="${basedir}/src/test/idl"
         */
        private List includeDirs;

I haven't actually tried but I could imagine this would choke when trying to assign a scalar value to a collection-typed field. So the default-value probably needs to be removed.

Furthermore, includeDirs is used as a List<String> where the strings denote paths. Without some form of manual basedir-alignment, relative paths won't work properly in reactor builds. Changing the field-type to File[] should be an easy fix.


Benjamin

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email


Reply via email to