Jar unsign does not remove certificate : comparison is case sensitive against
"DSA", "RSA" and "SF" file extensions
-------------------------------------------------------------------------------------------------------------------
Key: MWEBSTART-152
URL: http://jira.codehaus.org/browse/MWEBSTART-152
Project: Maven 2.x Webstart Plugin
Issue Type: Bug
Components: sign
Affects Versions: 1.0-beta-2
Environment: Ubuntu 10.4, JDK SUN 1.6.0_20
Reporter: Julien Graglia
Priority: Trivial
unsign detect that the jar is signed but can't remove the signed files from
META-INF folder :
logs :
[INFO] remove signature from : xxx.jar
[info] no files match {"DSA", "RSA", "SF"} : nothing to do for file: xxx.jar
jar contains :
$> jar tvf xxx.jar
....
11933 Sun Dec 03 00:00:00 CET 2006 META-INF/manifest.mf
11520 Sun Dec 03 00:00:00 CET 2006 META-INF/zigbert.sf
1868 Sun Dec 03 00:00:00 CET 2006 META-INF/zigbert.rsa
The jar is an (very) old jar signed with an old certificate. I don't know why
zigbert.sf/rsa are stored lowercase but that break unsign functionnality of the
plugin.
I have changed line 125 of
https://svn.codehaus.org/mojo/trunk/mojo/webstart/webstart-maven-plugin/src/main/java/org/codehaus/mojo/webstart/JarUnsignMojo.java
:
Patch :
Index: JarUnsignMojo.java
===================================================================
--- JarUnsignMojo.java (revision 12363)
+++ JarUnsignMojo.java (working copy)
@@ -122,7 +122,7 @@
public boolean accept( File file )
{
String extension = FileUtils.getExtension( file.getAbsolutePath()
);
- return ( extToRemove.contains( extension ) );
+ return ( extToRemove.contains( extension.toUpperCase() ) );
}
};
ps : org.codehaus.plexus.util.FileUtils.getExtension never return null, (the
extension of filename or "" if none)
It seems that my jar is a bit strange, the entries should have been stored
uppercase...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
