[
http://jira.codehaus.org/browse/MASPECTJ-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=244164#action_244164
]
Marvin Froeder commented on MASPECTJ-90:
----------------------------------------
Ops, forgot the patch:
{code}
Index: pom.xml
===================================================================
--- pom.xml (revision 13150)
+++ pom.xml (working copy)
@@ -79,6 +79,14 @@
</roles>
<timezone>+1</timezone>
</contributor>
+ <contributor>
+ <name>Marvin Froeder</name>
+ <email>[email protected]</email>
+ <roles>
+ <role>MASPECTJ-90</role>
+ </roles>
+ <timezone>-3</timezone>
+ </contributor>
</contributors>
<licenses>
<license>
Index: src/main/java/org/codehaus/mojo/aspectj/AjcHelper.java
===================================================================
--- src/main/java/org/codehaus/mojo/aspectj/AjcHelper.java (revision 13150)
+++ src/main/java/org/codehaus/mojo/aspectj/AjcHelper.java (working copy)
@@ -33,12 +33,11 @@
import java.io.IOException;
import java.util.ArrayList;
import java.util.Collections;
-import java.util.HashSet;
import java.util.Iterator;
import java.util.List;
import java.util.Properties;
import java.util.Set;
-import java.util.TreeSet;
+import java.util.LinkedHashSet;
import org.apache.commons.lang.SystemUtils;
import org.apache.maven.artifact.Artifact;
@@ -66,7 +65,7 @@
public static String createClassPath( MavenProject project, List
pluginArtifacts, List outDirs )
{
String cp = new String();
- Set classPathElements = Collections.synchronizedSet( new TreeSet() );
+ Set classPathElements = Collections.synchronizedSet( new
LinkedHashSet() );
classPathElements.addAll( project.getDependencyArtifacts() );
classPathElements.addAll( project.getArtifacts() );
classPathElements.addAll( pluginArtifacts == null ?
Collections.EMPTY_LIST : pluginArtifacts);
@@ -108,7 +107,7 @@
public static Set getBuildFilesForAjdtFile( String ajdtBuildDefFile, File
basedir )
throws MojoExecutionException
{
- Set result = new HashSet();
+ Set result = new LinkedHashSet();
Properties ajdtBuildProperties = new Properties();
try
@@ -140,7 +139,7 @@
public static Set getBuildFilesForSourceDirs( List sourceDirs, String[]
includes, String[] excludes )
throws MojoExecutionException
{
- Set result = new HashSet();
+ Set result = new LinkedHashSet();
Iterator it = sourceDirs.iterator();
while ( it.hasNext() )
@@ -269,7 +268,7 @@
protected static Set resolveIncludeExcludeString( String input, File
basedir )
throws MojoExecutionException
{
- Set inclExlSet = new HashSet();
+ Set inclExlSet = new LinkedHashSet();
try
{
if ( null == input || input.trim().equals( "" ) )
{code}
> Classhpath on aspectJ plugin doesn't respect the dependencies order
> -------------------------------------------------------------------
>
> Key: MASPECTJ-90
> URL: http://jira.codehaus.org/browse/MASPECTJ-90
> Project: Mojo AspectJ Plugin
> Issue Type: Bug
> Affects Versions: 1.2, 1.3, 1.4
> Environment: *
> Reporter: Marvin Froeder
>
> AspectJ classpath is completely out of order.
> The usage of TreeSet and HashSet on AjcHelper is causing that.
> Patch for it attached
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
