Improve branch info returned in scmBranch Property
--------------------------------------------------

                 Key: MOJO-1603
                 URL: http://jira.codehaus.org/browse/MOJO-1603
             Project: Mojo
          Issue Type: Improvement
          Components: buildnumber
    Affects Versions: buildnumber-maven-plugin-1.0-beta-4
         Environment: Win XP and HP-UX
            Reporter: phil
         Attachments: CreateMojo.java

Our SCM environment is Subversion. Currently, the scmBranch property set by the 
buildnumber plugin contains the string "trunk" if the scmUrl contains the 
substring "/trunk". If this is not the case *and* the scmUrl contains one of 
the substrings "/tags" or "/branches", then the complete path peginning with 
"tags" or "branches" is returned.

What I would have expected is the actual name of the branch/tag, i.e. the name 
of the directory right after/below tags/branches. Right now one of the problems 
is that if you use the scmBranch property to create filenames, subdirectories 
are created if you are in branch or tag of svn.

Say, we have a scmUrl like 
"http://subversion/svn/esb/branches/2010r4_Bugfix_20101129_639/";, then the 
string "branches/2010r4_Bugfix_20101129_639/" is returned. What I would expect 
to be returned is simply "2010r4_Bugfix_20101129_639", because this is the name 
of the branch.

I have attached a patched version of 
http://svn.codehaus.org/mojo/trunk/mojo/buildnumber-maven-plugin/src/main/java/org/codehaus/mojo/build/CreateMojo.java,
 there are only minor changes in the method filterBranchFromScmUrl(String 
scmUrl), lines 634 to 637.

I would love to see this fixed in beta-5. Or is it a feature?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to