[
http://jira.codehaus.org/browse/MASPECTJ-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=248621#action_248621
]
Will May edited comment on MASPECTJ-91 at 12/15/10 2:11 PM:
------------------------------------------------------------
According to the javadoc on the org.aspectj.tools.ajc.Main class, the aspectj
compiler is NOT thread safe. Therefore, the only way to solve this problem is
to have a lock around the compiler.
Attached is a patch which does this. I've run it a few times and the aspects
appear to get weaved correctly. Also included in the patch is configuration to
make the eclipse:eclipse command produce a usable project. Should this be
separated out or can it be left included in the patch?
EDIT: It also updates the version of plexus-utils used as according to
https://cwiki.apache.org/MAVEN/parallel-builds-in-maven-3.html, this version
has fixes for thread safety.
was (Author: willjmay):
According to the javadoc on the org.aspectj.tools.ajc.Main class, the
aspectj compiler is NOT thread safe. Therefore, the only way to solve this
problem is to have a lock around the compiler.
Attached is a patch which does this. I've run it a few times and the aspects
appear to get weaved correctly. Also included in the patch is configuration to
make the eclipse:eclipse command produce a usable project. Should this be
separated out or can it be left included in the patch?
> Mark aspectj plugin as @threadSafe if possible
> ----------------------------------------------
>
> Key: MASPECTJ-91
> URL: http://jira.codehaus.org/browse/MASPECTJ-91
> Project: Mojo AspectJ Plugin
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Simon Damouni
> Attachments: maspectj-91.patch
>
>
> Using this plugin with Maven 3 (Apache Maven 3.0 (r1004208; 2010-10-04
> 13:50:56+0200)
> throws following warning when executed in parallel:
> [WARNING] *****************************************************************
> [WARNING] * Your build is requesting parallel execution, but project *
> [WARNING] * contains the following plugin(s) that are not marked as *
> [WARNING] * @threadSafe to support parallel building. *
> [WARNING] * While this /may/ work fine, please look for plugin updates *
> [WARNING] * and/or request plugins be made thread-safe. *
> [WARNING] * If reporting an issue, report it against the plugin in *
> [WARNING] * question, not against maven-core *
> [WARNING] *****************************************************************
> [WARNING] The following plugins are not marked @threadSafe in ear assembly:
> [WARNING] org.codehaus.mojo:aspectj-maven-plugin:1.3
> [WARNING] *****************************************************************
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
