On 02/02/2011 01:22 AM, chemit wrote: > On Tue, 01 Feb 2011 17:40:52 -0600 > Paul Gier <[email protected]> wrote: > >> Tony, >> >> What do you think about changing the unit tests which currently use >> the maven plugin test harness to be additional ITs called by the >> invoker plugin? It seems that the plugin test harness is not actively >> maintained anymore, and these unit tests currently depend on the maven >> helper plugin tests. > Yes I was thinking about it too. >
I did some refactoring of the tests to remove the dependency on the nuiton helper plugin while still using the maven plugin test harness. So this part seems ok now. Next is refactoring of the main plugin classes to remove the other nuiton deps if possible. As Robert said, it looks like one of these deps uses jdk6 stuff, so at least that one should be removed. >> >> On 01/28/2011 10:23 AM, chemit wrote: >>> On Thu, 27 Jan 2011 15:17:42 -0600 >>> Paul Gier <[email protected]> wrote: >>> >>>> The nuiton maven-license-plugin [1] has been imported to codehaus >>>> svn and partially merged with the existing codehaus >>>> license-maven-plugin. Here are some notes about what needs to be >>>> done before the first release: >>>> >>>> - Add a bit more site documentation. Update the usage page and >>>> add at least basic usage examples for the goals >>>> >>>> - A couple of the ITs are failing on grid.sonatype.org [2]. They >>>> are passing for me locally, if anyone can give me karma to view >>>> the hudson workspace for these I would appreciate it :) >>> I perharps used in the settings.xml of its some of our >>> dependencies ? Need a doubled check. >>> >>>> >>>> - One of the dependency poms >>>> (org.nuiton:maven-helper-plugin:1.2.10) seems to be invalid due to >>>> missing dependency versions. This should be fixed if possible. >>> My idea will be to removed this dependecy but it is not so easy >>> since all mojos are extending it... >>> >>> I will have a look this week-end for sure :) >>> >>>> >>>> - The @since and deprecation tags refer to the original nuiton >>>> license plugin. How should these be handled considering that >>>> we'll be restarting the version numbers here at codehaus? >>>> >>>> There is currently duplication between the "download-licenses" and >>>> "add-third-party" goal. I'm thinking we should do one release >>>> (maybe a beta) before fully merging these goals since the merge >>>> looks to be not trivial. >>>> >>>> [1]http://maven-site.nuiton.org/maven-license-plugin/ >>>> [2]https://grid.sonatype.org/ci/job/mojo/jdk=java-6x,label=windows/1655/ >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe from this list, please visit: >>>> >>>> http://xircles.codehaus.org/manage_email >>>> >>>> >>> >>> >>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe from this list, please visit: >> >> http://xircles.codehaus.org/manage_email >> >> > > > --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
