[
https://jira.codehaus.org/browse/MWEBSTART-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=279121#comment-279121
]
Tony Chemit commented on MWEBSTART-149:
---------------------------------------
Yes Mathieu, that's extactly what I call a very "closed code" (being force to
use introspection to set fields in a class).
Don't you think it would be easier to improve the jarsigner mojo with simple
setters?
Anyway there is still another problem even with the setters added, the workdir
of the jarsigner is hardcoded with this
{code:java} commandLine.setWorkingDirectory( this.project.getBasedir() );
{code}
It reminds me that i should also put setters everywhere in webstart mojo...
> Add parameter maxMemory to the org.codehaus.mojo.webstart.JarSignMojoConfig
> fields
> ----------------------------------------------------------------------------------
>
> Key: MWEBSTART-149
> URL: https://jira.codehaus.org/browse/MWEBSTART-149
> Project: Maven 2.x Webstart Plugin
> Issue Type: Improvement
> Components: sign
> Affects Versions: 1.0-alpha-2
> Reporter: Mathieu Filotto
> Attachments:
> MWEBSTART-149_migrate_to_jarsigner_plugin_work_in_progress.1.patch
>
>
> When the size of the jar to sign is to big, we get a
> java.lang.OutOfMemoryError: Java heap space
> So it would be great to add the maxMemory to be able to set the Xmx.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
