[
https://jira.codehaus.org/browse/MOJO-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=282870#comment-282870
]
Robert Scholte commented on MOJO-1772:
--------------------------------------
I can think of 2 solutions:
- filter at the gate, which means: do the matches _before_ the {{Artifact dup =
classNames.get( name );}}. The only problem with this is loss of performance.
- Do the check in the {{if ( dups == null )}}-statement. The code will look a
bit complexer, but it should be possible.
And yes, I'd like to keep the logging.
> BanDuplicateClasses should only keep reference to non-ingored classes
> ---------------------------------------------------------------------
>
> Key: MOJO-1772
> URL: https://jira.codehaus.org/browse/MOJO-1772
> Project: Mojo
> Issue Type: Bug
> Components: extra-enforcer-rules
> Affects Versions: extra-enforcer-rules-1.0-alpha-2
> Reporter: Robert Scholte
>
> The current implementation is lazy, which might result in incorrect results.
> Unique classes are always added to {{classNames}}-List. If there's a second
> class with the same name, only the first class is checked if it should be
> ignored.
> So if the first one should not be ignored, but the second can, a false entry
> is added.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
