[
https://jira.codehaus.org/browse/MJAXB-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=284452#comment-284452
]
Lennart Jörelid commented on MJAXB-55:
--------------------------------------
Great with the feedback, gentlemen.
I see three comments above. Here are my thoughts regarding them:
a) Skin.
I am quite certain that there is a need to discuss a site skin change
between all the mojo projects
within codehaus. Feel free to start/carry on that discussion as you see fit.
The skin is needed by this patch since I refer to specific lines within the
code shown in the
faq and examples. AFAIK the only skin currently providing line numbering
within code snippets
is the fluido skin - if you know of any other means to achieve this effect,
please
point me in that direction.
I would guess that the need for line numbers/syntax coloring is not isolated
to the jaxb2-maven-plugin project.
Most other projects could (or should) document their usage with examples in
the same manner as I have tried
to do for the jaxb2-maven-plugin. I don't have any specific requirements
regarding the look of the skin - only
the line numbering/syntax coloring in code snippets is relevant. (C.f. the
comments within the "faq"
and "usage - schemagen").
b) Focus.
The focus of this patch has been 3 things - 2 features enhancements
(assigning file name, assigning prefix), and
1 documentation upgrade (there was no/insufficient documentation on
schemagen usage within the plugin site
before this patch). I would argue that the documentation improvements are
indeed within the focus of delivering
the patch.
In its current form, Doxia does not have a core mechanism to indicate that a
code block should be rendered with
line numbers or syntax coloring (although I am working on a patch for Doxia
to handle those mechanics).
c) Author tags.
I can certainly remove the company from the author tag - but not the author
tag itself.
All/most other files within the plugin have author tags, so I see no reason
why the files I
supplied should be without them. In fact, I think it is good practice to
credit the authors
in open source projects within the @author tag.
d) Patch size.
The patch is in total 5 classes and 1 interface, but the addition into the
existing framework consist
of only 1 property and 4 statements. The rest of the code is unit tests,
integration tests and
documentation. I have focused on readability and documentation within the
added classes, rather
than achieving the smallest patch size possible.
WRT verifying the patch, I recommend to start - as always - within the ITs.
Will fix the remaining issues tomorrow, and supply a new patch.
> Provide means to set the file name of generated XML schema
> ----------------------------------------------------------
>
> Key: MJAXB-55
> URL: https://jira.codehaus.org/browse/MJAXB-55
> Project: Maven 2.x JAXB 2.1 Plugin
> Issue Type: New Feature
> Affects Versions: 1.3.1
> Environment: All
> Reporter: Lennart Jörelid
> Assignee: Robert Scholte
> Attachments: fileRenamePatch_v8.txt
>
>
> AbstractSchemagenMojo sneakily hard-codes the resulting filename for the
> generated schema file.
> This should really be configurable; provided a parameter to set the resulting
> file name, as well as an integration test.
> For reasons of somewhat misguided backwards compatibility, I set the default
> value of the parameter to its currently hardcoded value, "schema1.xsd".
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
