[
https://jira.codehaus.org/browse/MJAXB-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=286169#comment-286169
]
Robert Scholte commented on MJAXB-55:
-------------------------------------
I've review it again. I've got a few request:
* Could you use xmlunit to compare xml documents? I've already added the
dependency. My problem is
org.codehaus.mojo.jaxb2.helpers.SchemagenHelperTest.validateProcessingNodes()
which seems to fail when using {{assertXMLEqual( changedDocument, document )}}
* TransformSchema should be a pojo, so return the {{toFile}} as is.
* Use {{org.codehaus.plexus.util.StringUtils.isEmpty(String)}} and
{{org.codehaus.plexus.util.StringUtils.isNotEmpty(String)}}, these are
null-safe methods.
* The validator is too strict. People can use expressions for certain values,
which can be empty. Don't throw an exception, just skip it.
* Add a workDirectory, where the schemaN.xsd can be placed. From here the mojo
can pick them up, transform it a write them to the outputDirectory.
* Add yourself as contributer in the pom
> Provide means to set the file name of generated XML schema
> ----------------------------------------------------------
>
> Key: MJAXB-55
> URL: https://jira.codehaus.org/browse/MJAXB-55
> Project: Maven 2.x JAXB 2.1 Plugin
> Issue Type: New Feature
> Affects Versions: 1.3.1
> Environment: All
> Reporter: Lennart Jörelid
> Assignee: Robert Scholte
> Attachments: diagramAdditions_1.png, fileRenamePatch_v10.txt,
> fileRenamePatch_v12.txt
>
>
> AbstractSchemagenMojo sneakily hard-codes the resulting filename for the
> generated schema file.
> This should really be configurable; provided a parameter to set the resulting
> file name, as well as an integration test.
> For reasons of somewhat misguided backwards compatibility, I set the default
> value of the parameter to its currently hardcoded value, "schema1.xsd".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
