[ 
https://jira.codehaus.org/browse/MOJO-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=289716#comment-289716
 ] 

Dan Tran commented on MOJO-1791:
--------------------------------

2 comments:

 1. The diff file really mess up.  It add and remove the same block too many 
places. So it is hard to review

 2. And why m2e support have need to alter the internal working code of this 
mojo?
                
> Add m2e lifecycle mapping metadata
> ----------------------------------
>
>                 Key: MOJO-1791
>                 URL: https://jira.codehaus.org/browse/MOJO-1791
>             Project: Mojo
>          Issue Type: New Feature
>          Components: truezip
>            Reporter: Pino Silvaggio
>         Attachments: truezip-buildapi.patch, truezip-buildapi.patch
>
>
> I have a working truezip plugin that works with m2e 1.1.
> I am using the new plexus-build-api which is discussed here: 
> http://wiki.eclipse.org/M2E_compatible_maven_plugins
> However, to minimize truezip execution under certain circumstances I have 
> introduced "markers"
> which checks the lastModified of the source against the marker. This is 
> complementary to
> the hasDelta of the buildContext. But, I am not sure about this. We 
> definitely need some form
> of control in the case where the source is not in the workspace and therefore 
> buildContext
> won't track the changes.
> We use truezip in our main project and this pattern seem to be working great. 
> But still,
> I do not know if this is the best solution. We would not want for truezip to 
> be copying
> after each incremental or auto build... This would be insane...
> Once I get feedback I would be happy to share the code.
> FYI: I already created and published (in catalog) the jaxb2 and xmlbeans m2e 
> connectors, found here: bitstrings.org

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to