On Thu, 17 May 2012 20:05:19 +0000
Robert Scholte <[email protected]> wrote:

> 
> Hi Tony, I've just checked the PMD, CPD and checkstyle reports and these 
> scores suggest there's a lot of room for improvements. And since this is the 
> license-m-p, at least all license related stuff should be good.The licenses 
> in the sourcefiles don't look correct:- they should be between the package 
> and the imports- such license-blocks are still full of placeholders. Is this 
> as expected? -Robert 


Oh no, None of this is expected :(

I have just fix PMD and CPD.

About license, since we are not using the Apache license v2, I have write a 
specific checkstyle-header and fixed all file headers.

I used the plugin it-self a long time ago to generate the file header but for 
java file it generates the license header at the top of the file (so before the 
package line).

All that is done in http://jira.codehaus.org/browse/MLICENSE-38

It could be interesting to add this new feature (I will do it now :).

Since I have done all this stuff, better to redo the release.

Thanks Robert for your close look.

> Date: Thu, 17 May 2012 21:18:14 +0200
> > From: [email protected]
> > To: mojo.codehaus.org [email protected]
> > Subject: [mojo-dev] [VOTE]  License Maven Plugin 1.1
> > 
> > Hello,
> > 
> > I'd like to release License Maven Plugin 1.1.
> > 
> > Some new features were introduced since the version 1.0 and 2 bug fixed.
> > 
> > There is still one issue in JIRA:
> > http://jira.codehaus.org/browse/MLICENSE 
> > 
> > Release Notes - Mojo's License Maven Plugin - Version 1.1
> > 
> > ** Bug
> >     * [MLICENSE-25] - license:add-third-party should operate on projects 
> > with "pom" packaging
> >     * [MLICENSE-34] - Multi-line copyright holders cannot be updated
> > 
> > ** Improvement
> >     * [MLICENSE-26] - The title of the site pages don't display the plugin 
> > name
> >     * [MLICENSE-27] - How to configure start and end process tags
> >     * [MLICENSE-30] - Allow template for description section that can 
> > include variables for filename, creation time etc.
> >     * [MLICENSE-33] - Add report goal license:third-party-report
> >     * [MLICENSE-35] - Clean code
> >     * [MLICENSE-36] - Create fromat string for dependencies' licenses list 
> > entry
> >     * [MLICENSE-37] - Make it possible to restrict which licenses are 
> > allowed in a project
> > 
> > Staging repo: 
> > https://nexus.codehaus.org/content/repositories/orgcodehausmojo-085/
> > 
> > Site: http://mojo.codehaus.org/license-maven-plugin/
> > 
> > [+1] Oh yeah! Do it!
> > [0] I don't care about it, do what you want
> > [-1] Oh no this is not possible, for this reason...
> > 
> > Here my +1.
> > 
> > The vote is open for 72 hours and will succeed by lazy consensus.
> > 
> > Thanks,
> > 
> > -- 
> > Tony Chemit
> > --------------------
> > tél: +33 (0) 2 40 50 29 28
> > email: [email protected]
> > http://www.codelutin.com
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe from this list, please visit:
> > 
> >     http://xircles.codehaus.org/manage_email
> > 
> > 
>                                         


-- 
Tony Chemit
--------------------
tél: +33 (0) 2 40 50 29 28
email: [email protected]
http://www.codelutin.com

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to