[mojo-dev] [jira] (MJAXB-71) Ensure no exception when a source directory does not exist

Wed, 15 Aug 2012 13:08:24 -0700

Lennart Jörelid commented on Improvement MJAXB-71

The scenario is more complex than that, Robert.
I believe that the majority of cases would mind that at least one - but not all - sourceDirectories exist.

Let me exemplify: Some plugins - such as the AspectJ Maven Plugin - add sourceDirectories to the project they are provided in.
In the case of the AspectJ plugin, src/main/aspect and src/test/aspect are added as sourceDirectories by default.
Maven promotes creating a commonly used build definition (such as AspectJ weaving many projects in a multimodule build and jaxb2 to
create schema for entity class definitions) in a parent pom.

So ... a parent pom with AspectJ and JAXB2 plugin definitions will always fail the build due to the implementation of the JAXB2 plugin
and the fact that a parent pom project frequently will not contain a src/main/aspect directory and src/test/aspect. Heck, even all
child projects might not contain these directories - and we should really avoid forcing developers to check in dummy files to ensure
that the src/main/aspect directory exists for all projects which are children to our example parent.
This is simply poor operation of the JAXB2 plugin.

While both the attached patch and your idea about a property failOnMissingSources could handle the scenario above, I would argue
that the default value should be false - so that the example above should work without having to provide extra configuration to
the JAXB2 plugin. We should use sensible default values to promote the spirit of maven's usage.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email

Reply via email to