With the Filters you filter classes From: [email protected] Date: Mon, 28 Jan 2013 22:38:49 +0100 To: [email protected] Subject: Re: [mojo-dev] Adding a new rule in extra-enforcer-rules? Enforcing bytecode version
Yup, good idea, this would be more common. I'll have a look in the next few days I guess. It's only working at the artifact level, right. If we also want to have some kind of in/exclusion of classes, we'll need another thing or did I miss something? Thanks 2013/1/28 Robert Scholte <[email protected]> How about http://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html#artifactSet and http://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html#filters From: [email protected] Date: Mon, 28 Jan 2013 22:29:26 +0100 To: [email protected] Subject: Re: [mojo-dev] Adding a new rule in extra-enforcer-rules? Enforcing bytecode version Hi,FYI, I just committed it with two ITs. I renamed it to EnforceBytecodeVersion. I think this still missed some exclusions parameters to be better. But I'm still unsure if those params should work at the dependency level (using GA[V]) or using the class level ([FQ]N?). I guess both might be useful. Let me know what you think. Cheers 2013/1/28 Baptiste MATHUS <[email protected]> OK. Thanks Robert. So I'll try adding it directly to trunk with the right IT so that it can be verified. Cheers 2013/1/27 Robert Scholte <[email protected]> Normally you can commit on the trunk. If you plan huge changes or you want to try something first, you could make a branch. There are enough developers following/reviewing the commits, so keep them small and use the maven coding format for easy reading. Depending on the commit a reference to jira and a unittest or integration test is a good practice. The description of the rules sounds interesting enough to me to be added to the extra-enforcer-rules. From: [email protected] Date: Sun, 27 Jan 2013 22:00:00 +0100 To: [email protected] Subject: [mojo-dev] Adding a new rule in extra-enforcer-rules? Enforcing bytecode version Hi all, On my github account [1], I have an enforcer rule I'd like to contribute extra-enforcer-rules. And btw, that one too [2] could easily be transformed into an enforcer rule. The questions is: as I'm still a bit new, I'm not sure about the process. Should I create a branch, directly commit to trunk, do something elsewhere and validate it (code and usefulnes) before modifying trunk? Thanks [1] https://github.com/Batmat/dependency-java-version-enforcer-rule#readme [2] https://github.com/Batmat/artifactchecker-maven-plugin -- Baptiste <Batmat> MATHUS - http://batmat.net Save A Tree, Eat A Beaver! -- Baptiste <Batmat> MATHUS - http://batmat.net Sauvez un arbre, Mangez un castor ! -- Baptiste <Batmat> MATHUS - http://batmat.net Sauvez un arbre, Mangez un castor ! nbsp;! -- Baptiste <Batmat> MATHUS - http://batmat.net Sauvez un arbre, Mangez un castor ! nbsp;!
