Hello Baptiste,
* You are quite right, accepted would be much better than expected.
* It is not optionalRoles, but the intention was that you may provide
roles which are accepted additionally, i.e. the union of requiredRoles
and validRoles are allowed (so may additionalValidRoles would have
been a more appropriate name).
* The intention is to have unique role names, e.g. only "responsible
developer" and not "rdev" or "resp. dev" or "resp. developer" or ...
and no made up roles ("senior software evangelist").
* In our case we want to know for every software component who is the
business and who is the technical responsible (might even be the same
person)..
Regards Mirko
--
http://illegalstateexception.blogspot.com/
https://github.com/mfriedenhagen/
https://bitbucket.org/mfriedenhagen/
On Tue, Mar 12, 2013 at 9:52 PM, Baptiste MATHUS <[email protected]> wrote:
> Hi all,
>
> I'm trying to tackle some issues on extra-enforcer-rules before releasing,
> since most of them are very simple.
>
> On this one: https://jira.codehaus.org/browse/MOJO-1841 even though the
> description is quite scarce, I must admit I'm having a hard time being sure
> I understand the doc page about "Require [Developer|Contributor] Rule" (see
> [1] or [2]))
>
> More precisely :
>
> requiredRoles - Comma separated list of roles which must be represented by
> at least one developer.
> validRoles - Comma separated list of roles which are allowed. requiredRoles
> are always valid. By default it has the value *, which means every role is
> excepted (accepted?). This rule does not support Ant-patterns.
>
> Maybe it's just me, but I don't really understand the sentence
> "requiredRoles are always valid".
> And without having jumped into the code, I would have thought from the param
> names requiredRoles should express values listed in validRoles, but it's not
> the case in the example:
>
> <requireContributorRoles>
> <requiredRoles>business engineer, quality
> manager</requiredContributorRoles>
> <validRoles>java developer<validRoles>
> </requireContributorRoles>
>
>
> Could someone (Mirko, I guess you created those rules?) help me understand
> it so that we can improve the doc?
>
> Thanks
> [1] http://mojo.codehaus.org/extra-enforcer-rules/requireDeveloperRoles.html
> [2]
> http://mojo.codehaus.org/extra-enforcer-rules/requireContributorRoles.html
>
> --
> Baptiste <Batmat> MATHUS - http://batmat.net
> Save a tree,
> Eat a beaver!
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
