[mojo-dev] [jira] (MSONAR-100) Sonar core should allow SCM branch name with a slash

Julien CARSIQUE (JIRA) Fri, 26 Sep 2014 08:18:45 -0700

Title: Message Title

Julien CARSIQUE created an issue

MSONAR-100

Issue Type:	Bug
Affects Versions:	2.4
Assignee:	Julien HENRY
Created:	26/Sep/14 10:17 AM
Priority:	Minor
Reporter:	Julien CARSIQUE

                                                    org.sonar.core.component.ComponentKeys.VALID_BRANCH_REGEXP
                                                
                                                    [40  private static final String VALID_BRANCH_REGEXP = "[\\p{Alnum}\\-_.]*";

This is a regression compared to Sonar 3.5.
For now, I didn't see any related issue with the existing projects having a slash in their name.

It's not that important as a feature but is an issue for the Jenkins Sonar Plugin which allows to configure the sonar.branch property. It is then legitimate to set this property with the variable $GIT_BRANCH provided by the Git Plugin:

                                                    https://wiki.jenkins-ci.org/display/JENKINS/Git+Plugin#GitPlugin-Environmentvariables
                                                
                                                     GIT_BRANCH - Name of the remote repository (defaults to origin), followed by name of the branch currently being used, e.g. "origin/master" or "origin/foo"

With GIT_BRANCH=origin/master, the execution fails with:

                                                    [ERROR] Failed to execute goal org.codehaus.mojo:sonar-maven-plugin:2.2:sonar (default-cli) on project nuxeo-ecm: Can not execute SonarQube analysis: Validation of project reactor failed:
[ERROR] o "origin/master" is not a valid branch name. Allowed characters are alphanumeric, '-', '_' and '.'.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.codehaus.mojo:sonar-maven-plugin:2.2:sonar (default-cli) on project nuxeo-ecm: Can not execute SonarQube analysis
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:216)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:317)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:152)
	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:555)
	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:214)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:158)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException: Can not execute SonarQube analysis
	at org.codehaus.mojo.sonar.Bootstraper.executeMojo(Bootstraper.java:109)
	at org.codehaus.mojo.sonar.Bootstraper.start(Bootstraper.java:67)
	at org.codehaus.mojo.sonar.SonarMojo.execute(SonarMojo.java:109)
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:106)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
	... 19 more
Caused by: org.apache.maven.plugin.MojoExecutionException: Validation of project reactor failed:
  o "origin/master" is not a valid branch name. Allowed characters are alphanumeric, '-', '_' and '.'.
	at org.sonar.maven.ExceptionHandling.handle(ExceptionHandling.java:37)
	at org.sonar.maven.SonarMojo.execute(SonarMojo.java:175)
	at org.codehaus.mojo.sonar.Bootstraper.executeMojo(Bootstraper.java:104)
	... 23 more
Caused by: org.sonar.api.utils.SonarException: Validation of project reactor failed:
  o "origin/master" is not a valid branch name. Allowed characters are alphanumeric, '-', '_' and '.'.
	at org.sonar.batch.scan.ProjectReactorValidator.validate(ProjectReactorValidator.java:69)
	at org.sonar.batch.scan.ProjectReactorReady.start(ProjectReactorReady.java:69)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.picocontainer.lifecycle.ReflectionLifecycleStrategy.invokeMethod(ReflectionLifecycleStrategy.java:110)
	at org.picocontainer.lifecycle.ReflectionLifecycleStrategy.start(ReflectionLifecycleStrategy.java:89)
	at org.picocontainer.injectors.AbstractInjectionFactory$LifecycleAdapter.start(AbstractInjectionFactory.java:84)
	at org.picocontainer.behaviors.AbstractBehavior.start(AbstractBehavior.java:169)
	at org.picocontainer.behaviors.Stored$RealComponentLifecycle.start(Stored.java:132)
	at org.picocontainer.behaviors.Stored.start(Stored.java:110)
	at org.picocontainer.DefaultPicoContainer.potentiallyStartAdapter(DefaultPicoContainer.java:1015)
	at org.picocontainer.DefaultPicoContainer.startAdapters(DefaultPicoContainer.java:1008)
	at org.picocontainer.DefaultPicoContainer.start(DefaultPicoContainer.java:766)
	at org.sonar.api.platform.ComponentContainer.startComponents(ComponentContainer.java:91)
	at org.sonar.api.platform.ComponentContainer.execute(ComponentContainer.java:77)
	at org.sonar.batch.scan.ScanTask.scan(ScanTask.java:64)
	at org.sonar.batch.scan.ScanTask.execute(ScanTask.java:51)
	at org.sonar.batch.bootstrap.TaskContainer.doAfterStart(TaskContainer.java:110)
	at org.sonar.api.platform.ComponentContainer.startComponents(ComponentContainer.java:92)
	at org.sonar.api.platform.ComponentContainer.execute(ComponentContainer.java:77)
	at org.sonar.batch.bootstrap.BootstrapContainer.executeTask(BootstrapContainer.java:185)
	at org.sonar.batch.bootstrapper.Batch.executeTask(Batch.java:95)
	at org.sonar.batch.bootstrapper.Batch.execute(Batch.java:67)
	at org.sonar.runner.batch.IsolatedLauncher.execute(IsolatedLauncher.java:45)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.sonar.runner.impl.BatchLauncher$1.delegateExecution(BatchLauncher.java:87)
	at org.sonar.runner.impl.BatchLauncher$1.run(BatchLauncher.java:75)
	at java.security.AccessController.doPrivileged(Native Method)
	at org.sonar.runner.impl.BatchLauncher.doExecute(BatchLauncher.java:69)
	at org.sonar.runner.impl.BatchLauncher.execute(BatchLauncher.java:50)
	at org.sonar.runner.api.EmbeddedRunner.doExecute(EmbeddedRunner.java:102)
	at org.sonar.runner.api.Runner.execute(Runner.java:90)
	at org.sonar.maven.SonarMojo.execute(SonarMojo.java:173)
	... 24 more
                                                

Is there any reason for the Sonar Core to restrict as much the branch naming?
If really so, then the Jenkins Sonar Plugin could at least normalize or strip the given value.

Add Comment

This message was sent by Atlassian JIRA



---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[mojo-dev] [jira] (MSONAR-100) Sonar core should allow SCM branch name with a slash

Reply via email to