[
https://issues.apache.org/jira/browse/MRQL-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781573#comment-13781573
]
Leonidas Fegaras commented on MRQL-19:
--------------------------------------
The following patch MRQL-19-2.patch addresses my previous comments and also
includes the changes from the MRQL-19.patch. In addition to the changes of
MRQL-19.patch:
1) it creates one independent jar for each evaluation mode: hadoop, hama, and
spark. It also creates a separate jar for the Gen library. The JLine and CUP
runtime libraries are not included in the the source nor in the binary
distribution
2) the script files in the bin/ directory were changed to bundle all the jar
files at runtime. In hadoop mode, this was done using the -libjars option. In
spark mode, this was done in the code using the addJar method. For hama, I
couldn't make the -libjars option work for the distributed mode (although it
worked for the local mode). So I had to merge all jars in a single jar in the
script bin/mrql.bsp.
Please vote +1 if you approve these changes.
If they are OK, I will apply the patch and I will stage the source distribution
for voting at the MRQL dev list.
> Fix license issues to prepare a new release candidate
> -----------------------------------------------------
>
> Key: MRQL-19
> URL: https://issues.apache.org/jira/browse/MRQL-19
> Project: MRQL
> Issue Type: Task
> Affects Versions: 0.9.0
> Reporter: Leonidas Fegaras
> Assignee: Leonidas Fegaras
> Fix For: 0.9.0
>
> Attachments: MRQL-19.2.patch, MRQL-19.patch
>
>
> We need to address the license issues reported by sebb before we stage a new
> release candidate for vote.
> Here are sebb's emails:
> http://markmail.org/message/z66lnr5q4u24rwal
> http://markmail.org/message/k7zvajrn3hnla3ve
> My opinion is that we should not release any binary artifacts. We release
> only source. The problem is that the generated jars must bundle all the
> dependencies (which are the runtime JLine and CUP libraries) in order to run
> as single jars on Hadoop or Hama. This means that we have to repeat the
> JLine/CUP classes in the MRQL jars, which is something sebb doesn't like.
> Also, if we release binaries, the license files of the source distribution
> must be different from that of the binary since we don't use JLine/CUP source
> code.
> What do you think?
> All the other issues are easy to fix.
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
