[ 
https://issues.apache.org/jira/browse/MRQL-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lee moon soo updated MRQL-32:
-----------------------------

    Attachment: MRQL-32_2.patch

I attached another patch which changes

1) directory name Gen, Spark, MapReduce, BSP to gen spark, mapreduce, bsp
2) change target directory of generated MapReduceEvaluator.java 
SparkEvaluator.java file
from 'src/main/java/org/apache/mrql'  
to 'target/generated-sources/org/apache/mrql'
by modifying mapreduce/pom.xml, spark/pom.xml

This patch(MRQL-32_2.patch) can be applied after applying MRQL-32.patch

> Refactoring directory structure for Eclipse
> -------------------------------------------
>
>                 Key: MRQL-32
>                 URL: https://issues.apache.org/jira/browse/MRQL-32
>             Project: MRQL
>          Issue Type: Improvement
>            Reporter: Lee moon soo
>            Assignee: Leonidas Fegaras
>            Priority: Critical
>         Attachments: MRQL-32.patch, MRQL-32_2.patch
>
>
> Currently all sources stays under /src.
> src/main/java/gen
> src/main/java/core
> src/main/java/BSP
> src/main/java/MapReduce
> src/main/java/spark
> I think it's better to move into each submodule with package named directory 
> tree. like
> Gen/src/main/java/org/apache/mrql/gen
> core/src/main/java/org/apache/mrql
> BSP/src/main/java/org/apache/mrql
> MapReduce/src/main/java/org/apache/mrql
> Spark/src/main/java/org/apache/mrql
> This directory structure gives some advantages
> 1. More common way.
> Most maven projects which has submodule keeps submodule's sources under 
> submodule directory. not in parent directory.
> Changing directory structure to more common way will make more developer 
> comfortable.
> 2. IDE compatible (Eclipse)
> mvn eclipse:eclipse generated project file makes src path error.
> Changing directory structure will help generating correct eclipse project 
> file.
> So developers can benefit from IDE.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to