[
https://issues.apache.org/jira/browse/MRUNIT-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423052#comment-13423052
]
Jim Donofrio commented on MRUNIT-124:
-------------------------------------
I would make moveLocalFiles not static and have it call getConfiguration
internally similar to most fo the other methods. moveLocalFiles should go in
TestDriver and not the mapred MapReduceDriverBase since the mapreduce api
drivers use it.
It is a style thing but to be consistent with the rest of the code I would
change your if statements to be if (uri.getFragment() != null) instead of if
(null != uri.getFragment()), same goes with that length check
Also I think it would be better to copy the file that call symlink in order to
fully support testing on Windows
For this null check if (null != uri) it might be better to throw an exception
to tell the user they passed in a bad filename
Please add some test cases
> DistributedCache should move files from getCacheFiles to getLocalCacheFiles
> ---------------------------------------------------------------------------
>
> Key: MRUNIT-124
> URL: https://issues.apache.org/jira/browse/MRUNIT-124
> Project: MRUnit
> Issue Type: Bug
> Affects Versions: 1.0.0
> Reporter: Nicholas Moore
> Priority: Trivial
> Labels: distributed_cache
> Fix For: 1.0.0
>
> Attachments: MRUnit.DistributedCache.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> When attempting to access files provided by the Distributed Cache Hadoop
> feature, DistributedCache.getLocalCacheFiles() is not populated. Instead, the
> files remain in DistributedCache.getCacheFiles().
> This may affect other uses of DistributedCache.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
