[
https://issues.apache.org/jira/browse/MRUNIT-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dave Beech updated MRUNIT-126:
------------------------------
Attachment: MRUNIT-126.patch
I've knocked up a quick patch for this.
I'd like your opinion on an unrelated change I've made at the same time. I
realised the runTest() methods are being duplicated in all the *DriverBase
methods, differing only by the debug logging at the top.
So, I've moved the actual runTest code into TestDriver and made a protected
method which gets overridden and does the debug logging in each individual
subclass.
If there are good reasons not to do this, I can revert and still make the
necessary change to resolve this JIRA without it.
> Counter tests are ignored if test is executed using run() rather than
> runTest()
> -------------------------------------------------------------------------------
>
> Key: MRUNIT-126
> URL: https://issues.apache.org/jira/browse/MRUNIT-126
> Project: MRUnit
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Dave Beech
> Assignee: Dave Beech
> Fix For: 1.0.0
>
> Attachments: MRUNIT-126.patch
>
>
> An alternative way of running an mrunit test is to call run(), which returns
> the output list to you for manual validation, rather than runTest() which
> validates everything automatically.
> If you run a test using the run() method, any counter tests you have
> specified via withCounter(..) etc are silently ignored, which may falsely
> give the impression that these tests have passed.
> At the very least we should give a warning that this is happening. Otherwise,
> we should make sure the counter validation is triggered in all cases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
