[
https://issues.apache.org/jira/browse/MRUNIT-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429431#comment-13429431
]
Bertrand Dechoux edited comment on MRUNIT-125 at 8/6/12 9:15 PM:
-----------------------------------------------------------------
Add patch of patch (without any additional 'final').
And 2 notes :
* Is that normal to have map input path stuff in TestDriver? I moved the
related fluent method there to be consistent but...
* Not related to the issue but do varargs have been considered for 'list of
inputs'? That's what is the closest to a list literal in Java (with type issues
in bonus, I know).
was (Author: bdechoux):
Add patch of patch.
And 2 notes :
* Is that normal to have map input path stuff in TestDriver? I moved the
related fluent method there to be consistent but...
* Not related to the issue but do varargs have been considered for 'list of
inputs'? That's what is the closest to a list literal in Java (with type issues
in bonus, I know).
> reduce duplicate code related to fluent methods with generics
> -------------------------------------------------------------
>
> Key: MRUNIT-125
> URL: https://issues.apache.org/jira/browse/MRUNIT-125
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Jim Donofrio
> Assignee: Bertrand Dechoux
> Fix For: 1.0.0
>
> Attachments: mrunit-125-2.diff, mrunit-125-patch.diff,
> mrunit-125-spoiler.diff, mrunit-125.diff
>
>
> There is a lot of duplicate code in order to provide fluent style with
> methods. We could reduce the duplicate code with generics by adding an
> unbound type parameter T to TestDriver and then all the fluent methods could
> go in TestDriver but return type T. The base classes, MapDriverBase etc,
> would just pass the T on so you would have:
> public abstract class TestDriver<K1, V1, K2, V2, T>
> public abstract class MapDriverBase<K1, V1, K2, V2, T> extends TestDriver<K1,
> V1, K2, V2, T>
> public class MapDriver<K1, V1, K2, V2> extends MapDriverBase<K1, V1, K2, V2,
> MapDriver<K1, V1, K2, V2>>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
