Well it's apache licensed so the license is the same. This seems to happen quite often amongst apache projects. I would just add a note of where it came from.
On Wed, Aug 8, 2012 at 5:39 PM, Dave Beech <[email protected]> wrote: > Could do that, yeah. Would we have to attribute it in any way? > > On 8 August 2012 23:31, Brock Noland <[email protected]> wrote: > > > Yeah we might have issues since hadoop pulls in commons-io. > > > > It's a simple enough method that we can copy the existing impl from > > commons-io? > > > > Brock > > > > On Wed, Aug 8, 2012 at 5:24 PM, Dave Beech <[email protected]> wrote: > > > > > In a few places now in MRUnit we're creating temp files / directories > as > > > part of testing (e.g. dist cache testing, MockMapredOutputFormat). > > > > > > These will obviously need to be cleaned up as part of the test > execution. > > > But, from experience I've found deleting files/folders from Java to be > > > pretty unreliable (especially if folders are not empty), so usually I'd > > use > > > commons-io FileUtils.forceDelete() to get the job done. > > > > > > I'd really like to be able to use this method in MRUnit, but adding a > new > > > dependency to the POM for one method just seems.... wrong. > > > > > > I don't know what's worse. Adding the dependency, or re-implementing > some > > > file deletion code that's already been done "properly" elsewhere. > > > > > > What's your opinion? > > > > > > Thanks, > > > Dave > > > > > > > > > > > -- > > Apache MRUnit - Unit testing MapReduce - > > http://incubator.apache.org/mrunit/ > > > -- Apache MRUnit - Unit testing MapReduce - http://incubator.apache.org/mrunit/
