[
https://issues.apache.org/jira/browse/MRUNIT-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433083#comment-13433083
]
Bertrand Dechoux commented on MRUNIT-140:
-----------------------------------------
> Don't forget the Apache header on the new Errors class.
Indeed. I will do it.
> Maybe do the grammar corrections on the counter error messages separately?
> Just so we keep the commits to a single issue each.
The patch is quite small. It won't be hard to split. I also think it would be
clearer if they are separated.
> I'm not sure we need to retain the delegating "formatValueList" method in
> TestDriver. Something to discuss...
I do not have a clear opinion on this. I kept the delegation because it is
called somewhere else when printing keys or values I think. Since it is
protected, it can be assumed that no MRUnit user is calling it. So it could be
removed indeed. What would you think of another class handling all the
parsing/formatting? There are also two other (deprecated) methods doing parsing
stuff.
> I will remove the TODO about Guava.
> TestDriver should use composition and have less responsilibities
> ----------------------------------------------------------------
>
> Key: MRUNIT-140
> URL: https://issues.apache.org/jira/browse/MRUNIT-140
> Project: MRUnit
> Issue Type: Task
> Reporter: Bertrand Dechoux
> Priority: Minor
> Attachments: mrunit-errors.diff
>
>
> Due to more and more (welcomed) refactorings, TestDriver is becoming bigger
> and bigger. Reducing code duplication is a good thing. But TestDriver begins
> to have too many responsibilities. A solution would be to use composition in
> order to extract responsibilities from it.
> I currently see a few topics that could profit from it:
> * Errors recording
> * Distributed Cache
> * Counter validation
> You are welcome to suggest more. This work might in the end also help with
> the implementation of the new API by providing a cleaner internal
> organisation of MRUnit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
