[ 
https://issues.apache.org/jira/browse/MRUNIT-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822277#comment-13822277
 ] 

Dennis Federico commented on MRUNIT-13:
---------------------------------------

Yesterday I was able to extract the important changes in JiangHan patch with a 
couple of improvements, in summary the classes impacted so far are:

(new) org.apache.hadoop.mrunit.internal.output.MockMultipleOutputs
(modified) org.apache.hadoop.mrunit.TestDriver
(modified) org.apache.hadoop.mrunit.mapreduce.MapDriver
(modified) org.apache.hadoop.mrunit.mapreduce.ReduceDriver
(new) org.apache.hadoop.mrunit.mapreduce.TestMultipleOutput

I want to work a little more on the the unit test and then I'll submit the 
first version of the patch.
I have two things that concerns me now that I have seen the patch applied and 
working:

1. The coupling to PowerMock (which I didn't considered before), the solution 
is simpler this way but I wasted hours because I forgot to add one class in the 
PrepareForTest annotation ... I think It wont be intuitive to build tests for 
MultipleOutputs like on other MRUnit scenarios... I have a couple of 
alternatives in mind but involves adding more methods to TestDriver to prepare 
the MultipleOutputs beforehand.

2. Counters... MultipleOutput counters are not considered in the Mock and I 
don't know if it makes sense to include them, because they come disable by 
default and its something you activate in the driver, no in the map or reduce.

> Add support for MultipleOutputs
> -------------------------------
>
>                 Key: MRUNIT-13
>                 URL: https://issues.apache.org/jira/browse/MRUNIT-13
>             Project: MRUnit
>          Issue Type: New Feature
>            Reporter: E. Sammer
>            Assignee: Jim Donofrio
>         Attachments: MRUNIT-13.patch, mapreduce.zip
>
>
> Add support to mrunit for Hadoop's MultipleOutputs.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to