----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15520/#review30563 -----------------------------------------------------------
Hi! The patch looks good and I'd like to commit it! Can you trim the trailing whitespace (shows up in red) and make sure the new files have two spaces per tab as opposed to 4? src/main/java/org/apache/hadoop/mrunit/TestDriver.java <https://reviews.apache.org/r/15520/#comment58526> Can you remove the whitespace issues? They show up in red. src/main/java/org/apache/hadoop/mrunit/internal/output/MockMultipleOutputs.java <https://reviews.apache.org/r/15520/#comment58528> I think this file has 4 spaces? It should have 2. src/main/java/org/apache/hadoop/mrunit/internal/output/MockMultipleOutputs.java <https://reviews.apache.org/r/15520/#comment58527> If this is not needed can we remove it? - Brock Noland On Nov. 14, 2013, 5:05 p.m., Dennis Federico wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15520/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2013, 5:05 p.m.) > > > Review request for mrunit. > > > Repository: mrunit > > > Description > ------- > > MRUNIT-13 Add support for MultipleOutputs > changes made from commit "trunk (8c3ca4869d9e9edb1e624803a5b2f8539f425dab)" > > > Diffs > ----- > > pom.xml 4fdfb7d > src/main/java/org/apache/hadoop/mrunit/TestDriver.java 487c17f > > src/main/java/org/apache/hadoop/mrunit/internal/output/MockMultipleOutputs.java > PRE-CREATION > src/main/java/org/apache/hadoop/mrunit/mapreduce/MapDriver.java 8f7b0a8 > src/main/java/org/apache/hadoop/mrunit/mapreduce/ReduceDriver.java b36ce4a > src/test/java/org/apache/hadoop/mrunit/mapreduce/TestMultipleOutput.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/15520/diff/ > > > Testing > ------- > > > Thanks, > > Dennis Federico > >
