[
https://issues.apache.org/jira/browse/MRUNIT-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985979#comment-13985979
]
Dave Beech commented on MRUNIT-208:
-----------------------------------
OK, thanks [~alexandre.normand]. I understand this now (sorry, it's been a
little while since I wrapped my head around Maven dependency scope!)
I think we're good to include mockito-core rather than mockito-all. We're not
actually excluding hamcrest and objenesis by doing so, they will be brought in
transitively for mrunit users by mockito-core's POM. We're using hamcrest
directly in our unit tests, so a test scope dependency makes sense for us too.
So, +1 from me. I'll commit this later unless anyone else wants to weigh in?
> mrunit unnecessarily depends on mockito-all
> -------------------------------------------
>
> Key: MRUNIT-208
> URL: https://issues.apache.org/jira/browse/MRUNIT-208
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Alexandre Normand
> Priority: Minor
> Attachments: MRUNIT-208.patch
>
>
> mrunit depends on mockito but it brings it in as {{mockito-all}}.
> {{mockito-all}} bundles {{hamcrest}} with it and makes it harder for
> downstream projects to manage/analyse their dependencies cleanly.
> I suggest that, to be a good citizen, mrunit declares explicit dependencies
> on {{mockito-core}} instead as well as a {{test}} scoped dependency on
> {{hamcrest-core}}.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
