@samskalicky commented on this pull request.


>  target_include_directories(customop_lib PUBLIC 
> ${CMAKE_CURRENT_SOURCE_DIR}/include/mxnet)
 target_include_directories(transposecsr_lib PUBLIC 
${CMAKE_CURRENT_SOURCE_DIR}/include/mxnet)
 target_include_directories(transposerowsp_lib PUBLIC 
${CMAKE_CURRENT_SOURCE_DIR}/include/mxnet)
 target_include_directories(subgraph_lib PUBLIC 
${CMAKE_CURRENT_SOURCE_DIR}/include/mxnet)
 target_include_directories(pass_lib PUBLIC 
${CMAKE_CURRENT_SOURCE_DIR}/include/mxnet)
 if(USE_CUDA)
-  add_library(customop_gpu_lib SHARED 
${CMAKE_CURRENT_SOURCE_DIR}/example/extensions/lib_custom_op/relu_lib.cu)
+  add_library(customop_gpu_lib SHARED 
${CMAKE_CURRENT_SOURCE_DIR}/example/extensions/lib_custom_op/relu_lib.cu 
${CMAKE_CURRENT_SOURCE_DIR}/src/lib_api.cc)

@ptrendx @DickJC123 can you guys help with this windows linking error when 
compiling with CUDA?
```
[2020-08-18T07:32:25.378Z] cmd.exe /C "cd . && "C:\Program 
Files\CMake\bin\cmake.exe" -E vs_link_dll 
--intdir=CMakeFiles\customop_gpu_lib.dir 
--rc=C:\PROGRA~2\WI3CF2~1\10\bin\100162~1.0\x64\rc.exe 
--mt=C:\PROGRA~2\WI3CF2~1\10\bin\100162~1.0\x64\mt.exe --manifests  -- 
C:\PROGRA~2\MICROS~1\2019\COMMUN~1\VC\Tools\MSVC\1425~1.286\bin\Hostx64\x64\link.exe
 /nologo 
CMakeFiles\customop_gpu_lib.dir\example\extensions\lib_custom_op\relu_lib.cu.obj
 CMakeFiles\customop_gpu_lib.dir\src\lib_api.cc.obj  
/out:libcustomop_gpu_lib.dll /implib:customop_gpu_lib.lib 
/pdb:libcustomop_gpu_lib.pdb /dll /version:0.0 /machine:x64  /INCREMENTAL:NO 
/OPT:REF /OPT:ICF -LIBPATH:C:\PROGRA~1\NVIDIA~2\CUDA\v10.2\lib\x64 
cudadevrt.lib  cudart_static.lib  cudadevrt.lib  cudart_static.lib  
kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib 
oleaut32.lib uuid.lib comdlg32.lib advapi32.lib  && cd ."
[2020-08-18T07:32:25.378Z] LINK: command 
"C:\PROGRA~2\MICROS~1\2019\COMMUN~1\VC\Tools\MSVC\1425~1.286\bin\Hostx64\x64\link.exe
 /nologo 
CMakeFiles\customop_gpu_lib.dir\example\extensions\lib_custom_op\relu_lib.cu.obj
 CMakeFiles\customop_gpu_lib.dir\src\lib_api.cc.obj 
/out:libcustomop_gpu_lib.dll /implib:customop_gpu_lib.lib 
/pdb:libcustomop_gpu_lib.pdb /dll /version:0.0 /machine:x64 /INCREMENTAL:NO 
/OPT:REF /OPT:ICF -LIBPATH:C:\PROGRA~1\NVIDIA~2\CUDA\v10.2\lib\x64 
cudadevrt.lib cudart_static.lib cudadevrt.lib cudart_static.lib kernel32.lib 
user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib 
comdlg32.lib advapi32.lib /MANIFEST 
/MANIFESTFILE:libcustomop_gpu_lib.dll.manifest" failed (exit code 1120) with 
the following output:
[2020-08-18T07:32:25.378Z] lib_api.cc.obj : error LNK2038: mismatch detected 
for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 
'MD_DynamicRelease' in relu_lib.cu.obj
```

-- 
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/18904#pullrequestreview-470108134

Reply via email to