@samskalicky commented on this pull request.
> target_include_directories(customop_lib PUBLIC
> ${CMAKE_CURRENT_SOURCE_DIR}/include/mxnet)
target_include_directories(transposecsr_lib PUBLIC
${CMAKE_CURRENT_SOURCE_DIR}/include/mxnet)
target_include_directories(transposerowsp_lib PUBLIC
${CMAKE_CURRENT_SOURCE_DIR}/include/mxnet)
target_include_directories(subgraph_lib PUBLIC
${CMAKE_CURRENT_SOURCE_DIR}/include/mxnet)
target_include_directories(pass_lib PUBLIC
${CMAKE_CURRENT_SOURCE_DIR}/include/mxnet)
if(USE_CUDA)
- add_library(customop_gpu_lib SHARED
${CMAKE_CURRENT_SOURCE_DIR}/example/extensions/lib_custom_op/relu_lib.cu)
+ add_library(customop_gpu_lib SHARED
${CMAKE_CURRENT_SOURCE_DIR}/example/extensions/lib_custom_op/relu_lib.cu
${CMAKE_CURRENT_SOURCE_DIR}/src/lib_api.cc)
I found
[this](https://discuss.mxnet.io/t/windows-build-libmxnet-dll-with-md-multithreaded-dll-runtime/1516):
> mxnet (and all its third parties) are configured to use the static runtime
> library (/MT), whereas the default behavior of Visual Studio and cmake it to
> use the dynamic runtime library (aka /MD or “MultiThreaded DLL”).
So I needed to tell windows `cl.exe` to compile with "MT":
```
target_compile_options(customop_gpu_lib PRIVATE
"$<$<COMPILE_LANGUAGE:CUDA>:-Xcompiler=-LD -MT>")
```
--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/18904#discussion_r474732108
