+1 (binding) -[Y] Are release files in correct location? -[Y] Do release files have the word incubating in their name? -[Y] Are the digital signature and hashes correct? -[Y] Does DISCLAIMER file exist? -[Y] Do LICENSE and NOTICE files exists? -[Y] Is the LICENSE and NOTICE text correct? -[Y] Is the NOTICE year correct? -[Y] License information is not mentioned in NOTICE? Is there any 3rd party code contained inside the release? If so: -[Y] Does the software have a compatible license? -[Y] Are all software licenses mentioned in LICENSE? -[Y] Is the full text of the licenses (or pointers to it) in LICENSE? Is any of this code Apache licensed? Do they have NOTICE files? If so: -[Y] Have relevant parts of those NOTICE files been added to this NOTICE file? -[Y] Do all source files have ASF headers? -[Y] Do the contents of the release match with what's tagged in version control? -[N] Are there any unexpected binary files in the release? -[Y] Can you compile from source? Are the instruction clear?
Built MXNet from source using instructions at [1] on an Ubuntu 18.04 Deep Learning Base AMI, with CUDA v11.0 and cuDNN v8.0.2 on AWS P3.16x (V100) instance. Ran ResNet50 model training and inference. [1] https://github.com/apache/incubator-mxnet/blob/1.8.0.rc1/docs/static_site/src/pages/get_started/build_from_source.md#building-mxnet On Sun, Oct 11, 2020 at 3:04 PM Marco de Abreu <[email protected]> wrote: > Manu, your voting is not binding since you're not a PPMC member yet. > > -Marco > > On Fri, Oct 9, 2020 at 11:31 PM Manu Seth <[email protected]> wrote: > > > +1 (binding) > > > > I built MXNet tag 1.8.0.rc1 from source following instructions on [1] > using > > cmake config file [2] on an Ubuntu 18.04 Deep Learning Base AMI, with > CUDA > > v11.0 and cuDNN v8.0.2, and tested it by running all non operator tests > in > > tests/python/gpu/ folder. > > > > [1] > > > > > https://github.com/apache/incubator-mxnet/blob/1.8.0.rc1/docs/static_site/src/pages/get_started/build_from_source.md#building-mxnet > > [2] > > > > > https://github.com/apache/incubator-mxnet/blob/1.8.0.rc1/config/linux_gpu.cmake > > > > Manu > > > > On Thu, Oct 8, 2020 at 8:01 PM Dick Carter <[email protected]> wrote: > > > > > +1 (binding) > > > > > > My testing involved taking the 1.8.0.rc1 codebase and adding the files > > > needed to build and run against my internal CI system. The value here > is > > > not in the number of build configurations per se, but in the number of > > > different GPU architectures tested. All the gpu unittests under > > > ./tests/python/{gpu,train,tensort} passed on machines with: A100, V100, > > > TU102, TU104, P100 and P40 GPUs. Also, all the cpu unittests under > > > ./tests/python/unittest passed (on a machine with a V100). > > > > > > The build was for ubuntu 18.04 with cuda 11.1 and cuDNN 8.0.4 using the > > > cmake command: > > > > > > cmake -GNinja -S. -DCMAKE_BUILD_TYPE=Release -Bbuild \ > > > -DUSE_MKLDNN=OFF -DMXNET_CUDA_ARCH="6.0 6.1 7.0 7.5 8.0" \ > > > -DUSE_CUDA=ON -DUSE_CUDNN=1 \ > > > -DUSE_NCCL=ON \ > > > -DUSE_DIST_KVSTORE=ON \ > > > -DONNX_NAMESPACE=onnx \ > > > -DUSE_NVTX=1 \ > > > -DUSE_INTGEMM=OFF \ > > > -DUSE_TENSORRT=1 > > > > > > The build includes my as-yet-unmerged PR > > > https://github.com/apache/incubator-mxnet/pull/19298, which corrects > > > unittest issues, not the framework's functioning. Because of the > build, > > > int gemm and mkldnn functionality was not tested. > > > > > > On 2020/10/06 21:25:38, "Skalicky, Sam" <[email protected]> > > > wrote: > > > > Dear MXNet community, > > > > > > > > This is the vote to release Apache MXNet (incubating) version 1.8.0. > > > Voting will start October 6, 23:59:59 PDT and close on September 9, > > > 23:59:59 PDT. > > > > > > > > Link to release notes: > > > > > https://cwiki.apache.org/confluence/display/MXNET/1.8.0+Release+Notes > > > > > > > > Link to release candidate: > > > > https://github.com/apache/incubator-mxnet/releases/tag/1.8.0.rc1 > > > > > > > > Link to source and signatures on apache dist server: > > > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.8.0.rc1 > > > > > > > > Please remember to TEST first before voting accordingly: > > > > +1 = approve > > > > +0 = no opinion > > > > -1 = disapprove (provide reason) > > > > > > > > Here are the changes comparing to 1.8.0.rc0: > > > > > > > > * backported PRs that were directly merged to v1.7.x (were missing > from > > > v1.x so also missing in v1.8.x) > > > > * fix for oneDNN/intGemm problem > > > > * fix for split_and_save > > > > * fixes for extensions > > > > > > > > Best regards, > > > > Sam Skalicky > > > > > > > > > > > > > > > > > > -- Sandeep Krishnamurthy
