Created a PR to resolve this issue. https://github.com/dmlc/mxnet/pull/6944
Please have a review if it is ok. On Thu, Jul 6, 2017 at 11:17 AM, Suneel Marthi <smar...@apache.org> wrote: > it clearly says that's for mini javascripts, images or PDFs - not for > source code. > > "Sometimes the situation of a file is such that the recommended Apache > source header is not appropriate. Examples would be within images, minified > JavaScript or PDFs. In those cases, the following shorter form may be > used." > > On Thu, Jul 6, 2017 at 2:06 PM, Tianqi Chen <tqc...@cs.washington.edu> > wrote: > > > I am refering to > > https://www.apache.org/legal/src-headers.html#is-a-short- > > form-of-the-source-header-available > > > > On Thu, Jul 6, 2017 at 10:51 AM, Suneel Marthi <smar...@apache.org> > wrote: > > > > > I am not aware of a shorter version. Below is the standard header that > > > needs to go into all the files. > > > > > > /* > > > * Licensed to the Apache Software Foundation (ASF) under one or more > > > * contributor license agreements. See the NOTICE file distributed > with > > > * this work for additional information regarding copyright ownership. > > > * The ASF licenses this file to You under the Apache License, Version > > 2.0 > > > * (the "License"); you may not use this file except in compliance with > > > * the License. You may obtain a copy of the License at > > > * > > > * http://www.apache.org/licenses/LICENSE-2.0 > > > * > > > * Unless required by applicable law or agreed to in writing, software > > > * distributed under the License is distributed on an "AS IS" BASIS, > > > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > > implied. > > > * See the License for the specific language governing permissions and > > > * limitations under the License. > > > */ > > > > > > > > > > > > > > > > > > > > > On Thu, Jul 6, 2017 at 12:56 PM, Tianqi Chen <tqc...@cs.washington.edu > > > > > wrote: > > > > > > > I did notice that there is a shorter version of the header. I think > we > > > > could use that ? > > > > > > > > Tianqi > > > > On Thu, Jul 6, 2017 at 8:58 AM Suneel Marthi <smar...@apache.org> > > wrote: > > > > > > > > > Yes its absolutely necessary that every file have a Apache license > > > > header - > > > > > and every project that comes into Apache does that. > > > > > No, its got to be at file level and not folder. > > > > > > > > > > Lookup RAT plugin - what all projects use to ensure that files have > > > > license > > > > > headers. > > > > > > > > > > On Thu, Jul 6, 2017 at 11:52 AM, Naveen Swamy <mnnav...@gmail.com> > > > > wrote: > > > > > > > > > > > that is a lot of edits to the source files just to include the > > > > > > license terms, this will also change the history of the files. > Can > > we > > > > > add a > > > > > > license file at a folder level and do this next time we touch the > > > file? > > > > > > Also Is this absolutely necessary? > > > > > > > > > > > > On Wed, Jul 5, 2017 at 11:28 PM, Henri Yandell < > bay...@apache.org> > > > > > wrote: > > > > > > > > > > > > > Thought I'd describe one of the first sets of changes we should > > > make > > > > > when > > > > > > > the code moves to an Apache git repo. > > > > > > > > > > > > > > We should update the licensing. > > > > > > > > > > > > > > 1) We should update the NOTICE file, once on Apache's source > > > control, > > > > > to > > > > > > > say: > > > > > > > > > > > > > > Apache MXNet > > > > > > > Copyright 2017 The Apache Software Foundation > > > > > > > This product includes software developed at > > > > > > > The Apache Software Foundation (http://www.apache.org/). > > > > > > > > > > > > > > 2) Every source file (basically all files bar images, binaries > > and > > > > test > > > > > > > data) should have a commented source header: > > > > > > > > > > > > > > Licensed to the Apache Software Foundation (ASF) under one > > > > > > > or more contributor license agreements. See the NOTICE file > > > > > > > distributed with this work for additional information > > > > > > > regarding copyright ownership. The ASF licenses this file > > > > > > > to you under the Apache License, Version 2.0 (the > > > > > > > "License"); you may not use this file except in compliance > > > > > > > with the License. You may obtain a copy of the License at > > > > > > > > > > > > > > http://www.apache.org/licenses/LICENSE-2.0 > > > > > > > > > > > > > > Unless required by applicable law or agreed to in writing, > > > > > > > software distributed under the License is distributed on an > > > > > > > "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > > > > > > > KIND, either express or implied. See the License for the > > > > > > > specific language governing permissions and limitations > > > > > > > under the License. > > > > > > > > > > > > > > > > > > > > > Described on this page: https://www.apache.org/legal/ > > > > src-headers.html > > > > > > > > > > > > > > --- > > > > > > > > > > > > > > Hope that's useful :) > > > > > > > > > > > > > > Hen > > > > > > > > > > > > > > > > > > > > > > > > > > > >
