+1 Before we can turn protected mode I feel we should first get to a stable CI pipeline. Sandeep is chasing down known breaking issues.
On Thu, Aug 31, 2017 at 10:27 AM, Hagay Lupesko <lupe...@gmail.com> wrote: > Build stability is a major issue, builds have been failing left and right > over the last week. Some of it is due to Jenkins slave issues, but some are > real regressions. > We need to be more strict in the code we're committing. > > I propose we configure our master to be a protected branch ( > https://help.github.com/articles/about-protected-branches/). > > Thoughts? > > On 2017-08-28 22:41, sandeep krishnamurthy <s...@gmail.com> wrote: > > Hello Committers and Contributors,> > > > > Due to unstable build pipelines, from past 1 week, PRs are being merged> > > after CR ignoring PR build status. Build pipeline is much more stable > than> > > last week and most of the build failures you see from now on, are likely > to> > > be a valid failure and hence, it is recommended to wait for PR builds, > see> > > the root cause of any build failures before proceeding with merges.> > > > > At this point of time, there are 2 intermittent issue yet to be fixed -> > > * Network error leading to GitHub requests throwing 404> > > * A conflict in artifacts generated between branches/PR - Cause unknown > yet.> > > These issues will be fixed soon.> > > > > > > -- > > > Sandeep Krishnamurthy> > > >
