Well, in the end, I guess, such issues can be always corrected with better documentation.
On Mon, Jun 25, 2018, 18:29 Anirudh <anirudh2...@gmail.com> wrote: > Hi, > > 1.2.1 (load_params) is backward compatible with 1.1.0 not with 1.2.0. > It does not adhere exactly with semver but it had to be made, to quickly > help our customers who were using the APIs incorrectly. > > Anirudh > > On Mon, Jun 25, 2018 at 5:42 PM, Sheng Zha <szha....@gmail.com> wrote: > > > save_parameters didn't exist in 1.2.0 so its addition usually isn't > > supposed to happen in a patch release if we stick to semantic > versioning. I > > couldn't find a discussion on this exception. Did it happen? > > > > Would people who used 1.2.0 to save models be able to load parameters in > > 1.2.1 using the reverted load_params? (i.e. is it backward compatible) > > > > -sz > > > > > > On Mon, Jun 25, 2018 at 4:07 PM, Anirudh <anirudh2...@gmail.com> wrote: > > > > > Hi Mu, > > > > > > The warining currently printed is "save_params is deprecated. Please > use > > > save_parameters." > > > Isn't this similar to what you are suggesting ? > > > > > > Anirudh > > > > > > On Mon, Jun 25, 2018 at 3:47 PM, Mu Li <muli....@gmail.com> wrote: > > > > > > > v1.2.1 will print a deprecating warning message when calling > > > > save_params. We should tell users clearly to replace "save_params" > with > > > > "save_parameters" or something else. > > > > > > > > On Mon, Jun 18, 2018 at 6:52 PM, Anirudh <anirudh2...@gmail.com> > > wrote: > > > > > > > > > Hi, > > > > > > > > > > This is the vote to release Apache MXNet (incubating) version > 1.2.1. > > > > Voting > > > > > will start now and close Thursday June 21st 7:00 PM PDT. > > > > > > > > > > Link to release candidate 1.2.1.rc0: > > > > > > > > > > https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0 > > > > > > > > > > View this page for installation instructions: > > > > > > > > > > https://mxnet.incubator.apache.org/install/index.html > > > > > > > > > > (Note: The README.md points to the 1.2.1 tag and does not work at > the > > > > > moment). > > > > > > > > > > Please remember to test first before voting accordingly. > > > > > > > > > > +1 = approve > > > > > +0 = no opinion > > > > > -1 = disapprove (provide reason) > > > > > > > > > > Anirudh > > > > > > > > > > > > > > >
