Hi Srihari Thanks for the document. We could add it to the relevant section in the wiki so it's easier to keep track whenever you feel comfortable with it. https://cwiki.apache.org/confluence/display/MXNET/Design+Proposals
The calls to synchronize and wait looks very similar. Shall we use polymorphism or a bridge pattern to abstract this common calls instead of using the preprocessor? both seem to use the same abstraction (streams). Using the suggested pattern instead of preprocessor would lead to code that is easier to maintain and instrument. A shortcoming would be if the APIs to abstract would be too different. Pedro. On Wed, Oct 24, 2018 at 6:13 AM Karnam, Srihari <srihari.kar...@amd.com> wrote: > Dear All, > > > Please review the design for Up-Streaming MXNet HIP Port. > > > > https://docs.google.com/document/d/1uGr1KPVDqDVUwnhM0vtmxkZZpE2Mf9slNF9e2IbwVj0/edit?usp=sharing > > > Regards, > > Srihari Karnam >
