Hi Mentors, https://www.apache.org/legal/src-headers.html#3party states the 5 rules for handling third-party code included in the project [1]. In particular PPMC shall handle major modifications on a case-by-case basis.
But the other rules state > 1. Do not modify or remove any copyright notices or licenses within third- party works. and > 2. Do not add the standard Apache License header to the top of third-party source files. The major modifications in question [2] are currently licensed under Apache License but the files originate from a third-party and there are thus two license headers in the files. This is in conflict with rule 2. Could you clarify if rule 2 is not a rule but only a guideline that can be overruled in PPMC's case-by-case decision? What's your recommendation? Ie. can we keep the 2 headers in place? Best regards Leonard [1]: > 0. The term "third-party work" refers to a work not submitted directly to the > ASF by the copyright owner or owner's agent. This includes parts of a work > submitted directly to the ASF for which the submitter is not the copyright > owner or owner's agent. > 1. Do not modify or remove any copyright notices or licenses within third- > party works. > 2. Do ensure that every third-party work includes its associated license, even > if that requires adding a copy of the license from the third-party download > site into the distribution. > 3. Do not add the standard Apache License header to the top of third-party > source files. > 4. Minor modifications/additions to third-party source files should typically > be licensed under the same terms as the rest of the rest of the third-party > source for convenience. > 5. Major modifications/additions to third-party should be dealt with on a > case-by-case basis by the PMC. [2]: https://github.com/apache/incubator-mxnet/issues/17329#issuecomment-641311199
