+1. I checked: [x] Are release files in correct location? Yes [x] Do release files have the word incubating in their name? Yes [x] Are the digital signature and hashes correct? Yes [x] Does DISCLAIMER file exist? Yes, DISCLAIMER-WIP [x] Do LICENSE and NOTICE files exists? Yes [x] Is the LICENSE and NOTICE text correct? Yes, though the license still reads "Copyright [yyyy] [name of copyright owner]", which needs correction.
[x] Is the NOTICE year correct? Yes [x] Un-included software dependencies are not mentioned in LICENSE or NOTICE? No. mshadow is now contributed to MXNet via software grant and should be removed from NOTICE. [x] License information is not mentioned in NOTICE? Confirmed Is there any 3rd party code contained inside the release? If so: [x] Does the software have a compatible license? Yes. Minor issue: Dual license in cmake/Modules/FindJeMalloc.cmake. [x] Are all software licenses mentioned in LICENSE? Yes [x] Is the full text of the licenses (or pointers to it) in LICENSE? Yes Is any of this code Apache licensed? Do they have NOTICE files? If so: [x] Have relevant parts of those NOTICE files been added to this NOTICE file? No. TVM NOTICE file hasn't been included. [x] Do all source files have ASF headers? Yes, except those in 3rdparty folder and those mentioned in license. [x] Do the contents of the release match with what's tagged in version control? Yes [x] Are there any unexpected binary files in the release? No [x] Can you compile from source? Are the instruction clear? Yes, Makefile is present and is straightforward. Is the issue minor? Yes Could it possibly be fixed in the next release? Yes I vote with: [x] +1 release the software On 2020/07/20 17:25:50, "Skalicky, Sam" <sska...@amazon.com.INVALID> wrote: > +1 > > Tested: > - Make flow building from source, verified all example/extensions/* work > correctly > - staticbuild flow cpu & cu102 variants producing the pip wheels, tested with > custom extension library > > Sam > > On 7/20/20, 4:07 AM, "Chen, Ciyong" <ciyong.c...@intel.com> wrote: > > CAUTION: This email originated from outside of the organization. Do not > click links or open attachments unless you can confirm the sender and know > the content is safe. > > > > Thanks Aston, Patric for the vote. > > Hi Community, > > I would like to call for action to test/validate/vote for the release > candidate (1.7.0.rc1). > As we've not reached the quorum, I would like to extend the voting > process to July 22, 23:59:59 PST. > Please prepare your time and provide feedback if you've tried with the > pre-released code base, thanks! > > Best Regards, > Ciyong > > -----Original Message----- > From: Zhao, Patric <patric.z...@intel.com> > Sent: Monday, July 20, 2020 11:36 AM > To: dev@mxnet.incubator.apache.org > Cc: d...@mxnet.apache.org; Bob Paulin <b...@apache.org>; Henri Yandell > <bay...@apache.org>; Jason Dai <jason...@apache.org>; Markus Weimer > <wei...@apache.org>; Michael Wall <mjw...@apache.org> > Subject: RE: [VOTE] Release Apache MXNet (incubating) version 1.7.0.rc1 > > +1 > > Passed the performance benchmarking for CPU tests and no regression is > found. > > > > -----Original Message----- > > From: Aston Zhang <astonlzh...@gmail.com> > > Sent: Sunday, July 19, 2020 1:45 PM > > To: dev@mxnet.incubator.apache.org > > Cc: d...@mxnet.apache.org; Bob Paulin <b...@apache.org>; Henri Yandell > > <bay...@apache.org>; Jason Dai <jason...@apache.org>; Markus Weimer > > <wei...@apache.org>; Michael Wall <mjw...@apache.org> > > Subject: Re: [VOTE] Release Apache MXNet (incubating) version > > 1.7.0.rc1 > > > > +1 > > Passed d2l-en v0.14.1: > > https://github.com/d2l-ai/d2l-en/releases/tag/v0.14.1 > > > > On Thu, Jul 16, 2020 at 2:34 AM Chen, Ciyong <ciyong.c...@intel.com> > wrote: > > > > > Dear MXNet community, > > > > > > This is the vote to release Apache MXNet (incubating) version 1.7.0. > > > Voting will start 16th July 23:59:59 PST and close on 19th July > > > 23:59:59 PST. > > > > > > Link to release notes: > > > https://cwiki.apache.org/confluence/display/MXNET/1.7.0+Release+note > > > s > > > > > > Link to release candidate: > > > https://github.com/apache/incubator-mxnet/releases/tag/1.7.0.rc1 > > > > > > Link to source and signatures on apache dist server: > > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.7.0.rc1 > > > > > > Please remember to TEST first before voting accordingly: > > > +1 = approve > > > +0 = no opinion > > > -1 = disapprove (provide reason) > > > > > > Here's the changes comparing to 1.7.0.rc0: > > > > > > * Revert "Fix memory leaks in Gluon (#18328) (#18358) (#18692) > > > * revise activations (#18700) > > > * Fix the monitor_callback invalid issue during calibration with > > > variable input shapes (#18632) (#18703) > > > > > > > > > Best regards, > > > Ciyong Chen > > > > >
