> Actually, I don't think we want to *require* download-dependencies > when running dist-all (or any other target.) Itwill be run as part of > the nightly and release targets (in bootstrap) but I don't think we > should require this step. Recall users have the option of supplying > their own libs and this would be a wasted step. > > sean
It's a step that only adds a second or two to the full build if nothing gets downloaded. If something does get downloaded, then you needed it anyway. If you supply your own libs then you have already taken on the task of modifying the build for your own needs (even if it is just a property change). My vote is to err on the side of making it as easy as possible for new developers to build the latest code. Any hindrance to building, like knowing that you have to run download-dependencies before you do anything else, discourages newcomers. Again, developers who are new to a project expect to be able to just do a full checkout and then type "ant". Stan > > On 7/7/05, Stan Silvert <[EMAIL PROTECTED]> wrote: > > Done. I added download-dependencies to the dist-all target. > > > > BTW, the portlet stuff looks fine. > > > > Stan Silvert > > JBoss, Inc. > > [EMAIL PROTECTED] > > callto://stansilvert > > > > > -----Original Message----- > > > From: Sean Schofield [mailto:[EMAIL PROTECTED] > > > Sent: Tuesday, July 05, 2005 3:05 PM > > > To: MyFaces Development > > > Subject: Re: MyFaces and Portlets [ was RE: Problem with TLD in new > > App > > > Distro] > > > > > > > Given that developers expect the plain old "ant" command to just > > work, > > > > shouldn't we make that dependent on the download-dependencies task? > > > > > > Good point, although I never use just "ant" ;-) Feel free to change > > > the build script to incorporate this change (and the necessary portlet > > > changes.) > > > > > > > Stan Silvert > > > > > > sean > >
