RE: [jira] Commented: (MYFACES-655) RequestMap doesn't implement putAll as it should

[Stan Silvert]

We talked about this for several days in the EG.  The discussion is stopped for now because I am waiting for a clarification from Ed.  Ed’s last comment was, “It turns out the Sun implementation already does this for clear() on all the maps.  I've just checked in a change to the javadocs to be more specific.”    However, I don’t know what Ed was referring to when he said “already does this”.  He hasn’t responded all week, so I am guessing that he is on vacation.  I’m sure it will be cleared up soon.     Stan Silvert JBoss, Inc. [EMAIL PROTECTED] callto://stansilvert From: Adam Winer [mailto:[EMAIL PROTECTED] Sent: Tuesday, October 04, 2005 6:53 PM To: MyFaces Development Subject: Re: [jira] Commented: (MYFACES-655) RequestMap doesn't implement putAll as it should   The single lamest thing is that the JSF spec doesn't explicitly say what methods should be supported. The second lamest thing is that the spec doesn't require that *all* methods be supported in all Maps, Lists, etc., across the board.  I should've pushed that in 1.2, since it's been bugging me since 1.0. As long as the spec doesn't say, for instance, that putAll() must throw an UnsupportedOperationException, the TCK shouldn't be requiring that it does.  This of course creates a portability problem, since code that works against MyFaces would break against the RI, but portability problems are the fault of spec folks - like me :) - not the TCK team's responsibility. (And, hey, Craig, why not send questions to the EG list instead of Ed and Roger?) Cheers, Adam On 10/4/05, Craig McClanahan (JIRA) <myfaces-dev@incubator.apache.org> wrote:     [ http://issues.apache.org/jira/browse/MYFACES-655?page=comments#action_12331258 ] Craig McClanahan commented on MYFACES-655: ------------------------------------------ Matthias has a fair question (about why the TCK requires UnsupportedOperattionException) here.  Forwarded to the spec leads for further comment. Craig > RequestMap doesn't implement putAll as it should > ------------------------------------------------ > >          Key: MYFACES-655 >          URL: http://issues.apache.org/jira/browse/MYFACES-655 >      Project: MyFaces >         Type: Bug >     Versions: 1.1.0 >     Reporter: Colin Sampaleanu >     Assignee: Mathias Broekelmann > > The JSF description of for the ExternalContext.getRequestMap() method says: > """Return a mutable Map representing the request scope attributes for the current application. The returned Map  must implement the entire contract for a modifiable map as described in the JavaDocs for java.util.Map. Modifications made in the Map must cause the corresponding changes in the set of request scope attributes.""" > yet MyFaces returns a RequestMap class which throws UnsupportedOperationException for both the putAll() and the clear() methods. > This is a major bug which will break apps (like mine) that depend on being able to add params via putAll(), for example. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators:    http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see:    http://www.atlassian.com/software/jira