[
http://issues.apache.org/jira/browse/MYFACES-700?page=comments#action_12332057
]
Simon Kitching commented on MYFACES-700:
----------------------------------------
Interestingly, the code also has:
if (themeName != null) {
...
} else {
...
}
However the tomahawk.tld file specifies that the themeName attribute is
required.
So presumably the "else" clause will never be used?
> incompatible change to jscookMenu
> ---------------------------------
>
> Key: MYFACES-700
> URL: http://issues.apache.org/jira/browse/MYFACES-700
> Project: MyFaces
> Type: Bug
> Components: Tomahawk
> Versions: 1.1.1
> Reporter: Simon Kitching
> Priority: Blocker
>
> The current version of the jscookMenu tag [R292680, 2005-10-13] now throws an
> exception, with message:
> "You provided a wrong themeName.".
> I see that new features have been added to support custom themes. This is
> fine, but please restore the original behaviour of accepting an unknown
> themeName value. A bump in the "patch-level" release number (1.1.0 -> 1.1.1)
> should not have changes that break valid existing user code.
> I currently implement a custom theme by passing my own theme name to the
> jscookMenu class and then ensuring that references to the appropriate .js and
> .css files are inserted into the page too. The old jscookMenu code simply
> accepted the unknown theme name, included that name in its generated inline
> javascript, and skipped output of any references to the .js/.css for a
> built-in theme.
> The problem change is to class
> org.apache.myfaces.custom.navmenu.jscookmenu.HtmlJSCookMenuRenderer
> Possibly a *warning* (logged or even output as a js comment) could be
> generated by the jscookMenu code to recommend to people that they modify
> their pages to use the new custom-theming attributes, but throwing an
> exception isn't nice.
> This has been discussed on the user email list:
> http://marc.theaimsgroup.com/?t=112864086400003&r=1&w=2
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
