[ http://issues.apache.org/jira/browse/MYFACES-701?page=comments#action_12356373 ]
Simon Kitching commented on MYFACES-701: ---------------------------------------- How has it been fixed? Recent commit r328404 adapted the class to the new AddResource API and cleaned up URL encoding Recent commit r328312 provided by Neal Haggard added support for jscookmenu to be used within a form. And commit 327111 made the class backwards compatible with MyFaces 1.1.0 and earlier by allowing a custom themeName without overriding javascriptLocation. But this isn't a complete solution, as using this approach means that <script> tags for the custom theme file and stylesheet need to be manually wired into the page in non-obvious ways. What's needed is a *clean* way to have custom themes without duplicating the core .js files, and I don't think there currently is any such thing. > Allow custom theme.js file without duplicating jscookmenu.js > ------------------------------------------------------------ > > Key: MYFACES-701 > URL: http://issues.apache.org/jira/browse/MYFACES-701 > Project: MyFaces > Type: Improvement > Components: Tomahawk > Versions: 1.1.1 > Reporter: Simon Kitching > Assignee: Martin Marinschek > Fix For: Nightly > > In release 1.1.0 and earlier, defining a custom theme for a jscookMenu > component was possible but rather clumsy. > Since the 1.1.0 release some code has been added to the jscookMenu component > to provide a new "javascriptLocation" attribute. > However it would appear that the "javascriptLocation" attribute is used to > locate the JSCookMenu.js and MyFacesHack.js files *as well as* the custom > theme's theme.js file. > Can this be separated into two different attributes? I would like to be able > to specify a theme.js file *without* having to extract the core files > "JSCookMenu.js" and "MyFacesHack.js" from the tomahawk jar and put them in > the same directory. > I think introducing a new attribute whose value is the URL of the custom > theme file is possible without causing any incompatibilities with prior > releases. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
