[ 
http://issues.apache.org/jira/browse/MYFACES-444?page=comments#action_12357262 
] 

Martin Marinschek commented on MYFACES-444:
-------------------------------------------

We'll wait patiently.

Thanks Ken!

regards,

Martin

> HtmlMessageRendererBase renders tooltip as message summary rather than detail
> -----------------------------------------------------------------------------
>
>          Key: MYFACES-444
>          URL: http://issues.apache.org/jira/browse/MYFACES-444
>      Project: MyFaces
>         Type: Bug
>   Components: Implementation
>     Versions: 1.0.9m9
>     Reporter: Ken Weiner
>     Assignee: Martin Marinschek

>
> The tooltip attribute description on 
> http://java.sun.com/j2ee/javaserverfaces/1.1/docs/tlddocs/h/message.html says 
> that the tooltip content should be composed of the message detail text.  
> However, the tooltip content in MyFaces is getting set to the message summary 
> text.  This happens in HtmlMessageRendererBase in the 
> renderSingleFacesMessage() method.  The code sets the title to the summary if 
> the tooltip is enabled.  Otherwise it uses the title attribute:
>         String summary = getSummary(facesContext, message, facesMessage, 
> messageClientId);
>         String detail = getDetail(facesContext, message, facesMessage, 
> messageClientId);
>         String title = getTitle(message);
>         boolean tooltip = isTooltip(message);
>         if (title == null && tooltip)
>         {
>             title = summary;
>         }
> Instead it should use the detail as follows:
>         String summary = getSummary(facesContext, message, facesMessage, 
> messageClientId);
>         String detail = getDetail(facesContext, message, facesMessage, 
> messageClientId);
>         String title = getTitle(message);
>         boolean tooltip = isTooltip(message);
>         if (title == null && tooltip)
>         {
>             title = detail;
>         }
> It might be argued that the tooltip should be set to the detail regardless of 
> whether the title attribute is set at all since the description of the title 
> attribute is "Advisory title information about markup elements generated for 
> this component."  If that is the case then the code should look like this:
>         String summary = getSummary(facesContext, message, facesMessage, 
> messageClientId);
>         String detail = getDetail(facesContext, message, facesMessage, 
> messageClientId);
>         String title = getTitle(message);
>         boolean tooltip = isTooltip(message);
>         if (tooltip)
>         {
>             title = detail;
>         }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to