Yes you are right... I will change it immediately

Simon Kitching wrote:
[EMAIL PROTECTED] wrote:

Author: werpu
Date: Tue Jan  3 13:52:40 2006
New Revision: 365751

URL: http://svn.apache.org/viewcvs?rev=365751&view=rev
Log:
fixed a bug, which caused the jdk 1.4 to fail on the BigDecimal constructors

Modified:
myfaces/examples/trunk/simple/src/main/java/org/apache/myfaces/examples/listexample/SimpleCountryList.java

- _countries.add(new SimpleCountry(1, "AUSTRIA", "AT", new BigDecimal(123), createCities(new String[]{"Wien","Graz","Linz","Salzburg"}))); + _countries.add(new SimpleCountry(1, "AUSTRIA", "AT", new BigDecimal((long)123), createCities(new String[]{"Wien","Graz","Linz","Salzburg"})));


Wouldn't it be better to use this?
  new BigDecimal(123L)

This will definitely store the constant in the class as a LONG type. The "(long)123" syntax might store the constant as an int, then perform the typecast at runtime.

Of course it's a pretty minor point...

Cheers,

Simon



Reply via email to