Few added methods which are not called from anywhere in the code can't possibly break something.
The risk that this breaks something is minimal. If you look at the patch it is all it does - adds 4 new methods to a class
Release early, release often. I think you could have included it into 1.1.2 too
Thanks,
--Mike
On 5/3/06, Sean Schofield <
[EMAIL PROTECTED]> wrote:
Sorry, that release is locked down and the vote is closed. We don't
like to inject last minute stuff into the release. Besides all of the
work that goes into preparting and testing a release, we may break
something.
I will take a look and see if I can't apply the patch in the nightly
trunk for you.
Sean
On 5/3/06, Mikhail Grushinskiy <[EMAIL PROTECTED]> wrote:
> Would it be possible to include this patch into tomahawk 1.1.2 /1.1.3 before
> the Monday release?
> http://issues.apache.org/jira/browse/TOMAHAWK-388
>
> Thanks,
> --Mike
>
>
> On 5/3/06, Sean Schofield <[EMAIL PROTECTED]> wrote:
> > (6) +1 votes.
> >
> > I didn't count Werner or Mike since we are in fact going to release a
> > new version of core. So I assume they are no longer 0 or -1. We will
> > release both Tomahawk 1.1.2 and Core 1.1.3 on Monday (peding the
> > successful core vote.)
> >
> > Sean
> >
> > On 4/22/06, Dennis Byrne <[EMAIL PROTECTED]> wrote:
> > > +1 to release T 1.1.2
> > >
> > > ... but only if Core 1.1.3 ( w/ bug fix ) is to be released soon *and*
> there is no announcement on the site or mailing list about T until both it
> and Core are released.
> > >
> > > Dennis Byrne
> > >
> > > >-----Original Message-----
> > > >From: Sean Schofield [mailto:[EMAIL PROTECTED]]
> > > >Sent: Friday, April 21, 2006 08:51 PM
> > > >To: 'MyFaces Development'
> > > >Subject: [VOTE] Release Tomahawk 1.1.2
> > > >
> > > >This is a vote to release Tomahawk 1.1.2 (and its dependencies:
> > > >MyFaces Shared 2.0.1 and MyFaces Maven 1.0.2.)
> > > >
> > > >There is a non-trivial issue (TOMAHAWK-373) but this requires another
> > > >core release. I think the best thing to do is to release tomahawk
> > > >with this problem and quickly follow up with another core release
> > > >(this time including all of the goodies from the trunk that were added
> > > >during the long core branch.)
> > > >
> > > >+1 for my vote
> > > >
> > > >@Mario: Does TOMAHAWK-373 affect anything else other then tree2? If
> > > >so, then I change my vote to -1.
> > > >
> > >
> > >
> > >
> >
>
>
