[ 
http://issues.apache.org/jira/browse/MYFACES-1396?page=comments#action_12459946 
] 
            
Paul Pogonyshev commented on MYFACES-1396:
------------------------------------------

I didn't create a patch since I didn't feel it is a proper fix for upstream 
version.  And now I can't create one since SVN checkout commands on your site 
are broken.

Anyway, let me describe it in more words:
- when instance of 
org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlResponseWriterImpl is 
created (note: shared_tomahawk, not shared_impl!), it is passed "UTF8", without 
hyphen, as `characterEncoding';
- in all (or at least all relevant) cases before, charset is "UTF-8", with 
hyphen, as expected; in particular this is true for 
org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlResponseWriterImpl (note: 
shared_impl, not shared_tomahawk);
- I fixed it by converting "UTF8" string to "UTF-8" in HtmlResponseWriterImpl 
constructor;
- a proper fix would be find out why charset becomes "UTF8", without hyphen, in 
the first place; ad-hoc fix above could be included too, as a way to make 
HtmlResponseWriterImpl more robust.


> Too much escaping
> -----------------
>
>                 Key: MYFACES-1396
>                 URL: http://issues.apache.org/jira/browse/MYFACES-1396
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: General
>            Reporter: Tomas Fischer
>         Assigned To: Martin Marinschek
>            Priority: Blocker
>         Attachments: test.jsf
>
>
> HTMLOutputText (which delegates to HTMLEncoder) escapes not only XML-invalid 
> charactres (like <, >, &), but also german umlauts. This is OK if generating 
> (X)HTML, but not OK if generating XML. However, according to the official 
> documentation to the outputText Tag the german umlauts should not be quoted: 
> If the "escape" attribute is not present, or it is present and its value is 
> "true" all angle brackets should be converted to the ampersand xx semicolon 
> syntax when rendering the value of the "value" attribute as the value of the 
> component.
> There is an automatic XML detection, but this is broken, as only predefined 
> MIME-types are recognized (application/xhtml+xml, application/xml, text/xml).
> This bug prevents using JSF for generating other content (e.g. SVG, MIME-type 
> image/svg+xml).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to