Hi!
> The constructor for class ConversationContext takes a
> ConversationManager object as a parameter (ie a ref to its "parent"),
> but never uses it.
>
> Is there some future intention to do something with this parameter, or
> can it be removed?
>   
Might be a relict from previous times. Let's remove it for now.

> In CurrentConversationAdvice.invoke, the finally clause has the previous
> conversation being restored as the last step. Is it ok to make this the
> first step instead, just in case one of the other steps throws an
> exception? I've looked at the code and run the unit tests and there
> seems no reason not to. Yes, it's pretty minor :-)
>   
+1

Ciao,
Mario

Reply via email to