Hi Martin, > If there is no voices against this code, I'll commit it after SoC has > stopped. sounds great! So, might this happen about early September (as I believe Google SoC is stopping by the end of August)?
Thanks, Carsten Martin Marinschek wrote: > > Hi Carsten, > > sure you can speak up on development issues - the dev-list only means > that no requests should be voiced directly here which do not have > anything to do with the further development of this project, it > doesn't mean that users need to remain silent. > > In any case, I'll support your opinion (well, yes, it was me who asked > Leonardo to do this originally in his Google SoC assignment). If there > is no voices against this code, I'll commit it after SoC has stopped. > > regards, > > Martin > > On 8/13/07, Carsten Pieper <[EMAIL PROTECTED]> wrote: >> >> Hi, >> >> (preliminary note: I felt a little unsure whether to post this reply in >> this >> developer's >> forum as I am clearly neither developer nor contributor, just user... If >> these kind >> of people should stay away from the dev forum, please tell me so!) >> >> we justed wanted to make known, that Leonardo's TableFormLayout >> definetely >> looks promising to us. It would facilitate our page layouting a lot, so >> we >> would love >> to see it's being included in the library (wondering slightly nobody said >> this here >> before ;-} )! >> >> Best regards, >> Carsten >> >> >> My Faces - Dev mailing list wrote: >> > >> > Layout Component for Trinidad - TableFormLayout >> > ----------------------------------------------- >> > >> > Key: TRINIDAD-115 >> > URL: >> https://issues.apache.org/jira/browse/TRINIDAD-115 >> > Project: MyFaces Trinidad >> > Issue Type: Improvement >> > Components: Components >> > Reporter: Leonardo Uribe >> > Priority: Minor >> > >> > >> > Hi >> > >> > I want to put on consideration or discusion of the community this >> > component that I have made to work with trinidad. >> > >> > The component is similar to <tc:gridLayout> component in tobago, but >> are >> > build following the rules >> > of trinidad to manage this components. >> > >> > The component was build based on panelFormLayout way to do this >> > >> > I have attached to this issue a project called TableFormLayout. But >> for >> > run, It's necessary to modify a >> > method (really add a single line) of the class LabelAndMessageRenderer >> (I >> > also provide a patch) on >> > trinidad-impl-1.0.2-SNAPSHOT >> > >> > private boolean _isFormRendererType(String rendererType) >> > { >> > return "org.apache.myfaces.trinidad.Form".equals(rendererType) || >> > "org.apache.myfaces.trinidad.FormLayout".equals(rendererType) >> || >> > "org.apache.myfaces.trinidad.rich.Form".equals(rendererType) || >> > "org.apache.myfaces.trinidad.TableLayout".equals(rendererType); >> > } >> > >> > I don't like this patch, but LabelAndMessageRenderer has some coupling >> > with PanelFormLayoutRenderer. The central >> > problem is that this renderer has to look things about its environment, >> > but a component should not assume things >> > of his environment. I want to discuss this in another discusion in >> > myfaces-dev mailing list. >> > >> > The component is not finished yet, but i have made 3 examples that I >> want >> > to show to the community in order to >> > modify it. >> > >> > Suggestions are welcome. >> > >> > regards >> > >> > Leonardo Uribe >> > >> > >> > >> > -- >> > This message is automatically generated by JIRA. >> > - >> > You can reply to this email to add a comment to the issue online. >> > >> > >> > >> >> -- >> View this message in context: >> http://www.nabble.com/-jira--Created%3A-%28TRINIDAD-115%29-Layout-Component-for-Trinidad---TableFormLayout-tf4113391.html#a12121405 >> Sent from the My Faces - Dev mailing list archive at Nabble.com. >> >> > > > -- > > http://www.irian.at > > Your JSF powerhouse - > JSF Consulting, Development and > Courses in English and German > > Professional Support for Apache MyFaces > > -- View this message in context: http://www.nabble.com/-jira--Created%3A-%28TRINIDAD-115%29-Layout-Component-for-Trinidad---TableFormLayout-tf4113391.html#a12121587 Sent from the My Faces - Dev mailing list archive at Nabble.com.
